[Misc] Use Collection.isEmpty() instead of size() > 0 / size() === 0

Author: manuelleduc

xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-pageobjects/src/main/java/org/xwiki/administration/test/po/AdministrationMenu.java

@@ -82,12 +82,12 @@ public boolean hasCategoryWithName(String categoryName)
 
     public boolean hasNotCategoryWithId(String categoryId)
     {
-        return getDriver().findElementsWithoutWaiting(this.container, categoryById(categoryId)).size() == 0;
+        return getDriver().findElementsWithoutWaiting(this.container, categoryById(categoryId)).isEmpty();
     }
 
     public boolean hasNotCategoryWithName(String categoryName)
     {
-        return getDriver().findElementsWithoutWaiting(this.container, categoryByName(categoryName)).size() == 0;
+        return getDriver().findElementsWithoutWaiting(this.container, categoryByName(categoryName)).isEmpty();
     }
 
     public AdministrationMenu expandCategoryWithId(String categoryId)
@@ -143,13 +143,13 @@ public boolean hasSectionWithName(String categoryName, String sectionName)
 
     public boolean hasNotSectionWithId(String sectionId)
     {
-        return getDriver().findElementsWithoutWaiting(this.container, sectionById(sectionId)).size() == 0;
+        return getDriver().findElementsWithoutWaiting(this.container, sectionById(sectionId)).isEmpty();
     }
 
     public boolean hasNotSectionWithName(String categoryName, String sectionName)
     {
         return getDriver().findElementsWithoutWaiting(this.container, sectionByName(categoryName, sectionName))
-            .size() == 0;
+            .isEmpty();
     }
 
     /**

xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-pageobjects/src/main/java/org/xwiki/administration/test/po/RegistrationModal.java

@@ -70,6 +70,6 @@ public boolean validationFailureMessagesInclude(String message)
         By serverSideErrorMessage =
             By.xpath(String.format("//div[contains(@class,'xnotification-error') and contains(., '%s')]", message));
         return super.validationFailureMessagesInclude(message)
-            || getDriver().findElementsWithoutWaiting(serverSideErrorMessage).size() > 0;
+            || !getDriver().findElementsWithoutWaiting(serverSideErrorMessage).isEmpty();
     }
 }

xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-core/src/main/java/org/xwiki/annotation/internal/renderer/AnnotationGeneratorChainingListener.java

@@ -323,7 +323,7 @@ protected void addAnnotationEvent(AnnotationEvent evt, List<AnnotationEvent> lis
     {
         // if there is no event in the list, or the event is a start event or there is no start event in the list, just
         // append the event to the end of the list
-        if (list.size() == 0 || evt.getType() == AnnotationEventType.START
+        if (list.isEmpty() || evt.getType() == AnnotationEventType.START
             || list.get(list.size() - 1).getType() == AnnotationEventType.END) {
             list.add(evt);
         } else {

xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-maintainer/src/main/java/org/xwiki/annotation/maintainer/AbstractAnnotationMaintainer.java

@@ -89,7 +89,7 @@ public void updateAnnotations(String target, String previousContent, String curr
         try {
             annotations = ioService.getAnnotations(target);
 
-            if (annotations.size() == 0) {
+            if (annotations.isEmpty()) {
                 // no annotations, nothing to do
                 return;
             }
@@ -107,7 +107,7 @@ public void updateAnnotations(String target, String previousContent, String curr
                 getDiffService().getDifferences(renderedPreviousContent, renderedCurrentContent);
             // if any differences: note that there can be updates on the content that have no influence on the plain
             // text space normalized version
-            if (differences.size() > 0) {
+            if (!differences.isEmpty()) {
                 // compute the spaceless version of the renderedPreviousContent to be able to map the annotation on it
                 // (so that matching is done in the same way as for rendering), and then go back to the normalized
                 // version
@@ -329,7 +329,7 @@ private void ensureUnique(Annotation annotation, String content, int cStart, int
     {
         // find out if there is another encounter of the selection text & context than the one at cStart
         List<Integer> occurrences = getOccurrences(content, annotation.getSelectionInContext(), cStart);
-        if (occurrences.size() == 0) {
+        if (occurrences.isEmpty()) {
             // it appears only once, it's done
             return;
         }

xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-test/xwiki-platform-annotation-test-pageobjects/src/main/java/org/xwiki/annotation/test/po/AnnotatableViewPage.java

@@ -286,7 +286,7 @@ public void selectText(String annotationWord)
 
     public boolean checkIfAnnotationsAreDisabled()
     {
-        if (getDriver().findElementsWithoutWaiting(By.id("annotationsdisplay")).size() > 0) {
+        if (!getDriver().findElementsWithoutWaiting(By.id("annotationsdisplay")).isEmpty()) {
             return false;
         } else {
             return true;

xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-test/xwiki-platform-annotation-test-pageobjects/src/main/java/org/xwiki/annotation/test/po/AnnotationsPane.java

@@ -112,7 +112,7 @@ public void clickHideAnnotations()
      */
     public boolean checkIfShowAnnotationsCheckboxExists()
     {
-        if (getDriver().findElementsWithoutWaiting(By.id("annotationsdisplay")).size() > 0) {
+        if (!getDriver().findElementsWithoutWaiting(By.id("annotationsdisplay")).isEmpty()) {
             return true;
         } else {
             return false;

xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform-appwithinminutes-test/xwiki-platform-appwithinminutes-test-pageobjects/src/main/java/org/xwiki/appwithinminutes/test/po/ApplicationClassEditPage.java

@@ -95,7 +95,7 @@ public ApplicationCreatePage clickPreviousStep()
      */
     public boolean hasPreviousStep()
     {
-        return getDriver().findElementsWithoutWaiting(By.linkText("Previous Step")).size() > 0;
+        return !getDriver().findElementsWithoutWaiting(By.linkText("Previous Step")).isEmpty();
     }
 
     /**

xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform-appwithinminutes-test/xwiki-platform-appwithinminutes-test-pageobjects/src/main/java/org/xwiki/appwithinminutes/test/po/ApplicationHomeEditPage.java

@@ -213,7 +213,7 @@ public boolean hasLiveTableColumn(String columnLabel)
     {
         String escapedColumnLabel = columnLabel.replace("\\", "\\\\").replace("'", "\\'");
         String xpath = "//ul[@class = 'hList']/li[starts-with(., '" + escapedColumnLabel + "')]";
-        return getDriver().findElementsWithoutWaiting(getForm(), By.xpath(xpath)).size() > 0;
+        return !getDriver().findElementsWithoutWaiting(getForm(), By.xpath(xpath)).isEmpty();
     }
 
     /**

xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform-appwithinminutes-test/xwiki-platform-appwithinminutes-test-pageobjects/src/main/java/org/xwiki/appwithinminutes/test/po/ApplicationHomePage.java

@@ -107,7 +107,7 @@ public LiveTableElement getEntriesLiveTable()
      */
     public boolean hasEntriesLiveTable()
     {
-        return getDriver().findElements(By.className("xwiki-livetable")).size() > 0;
+        return !getDriver().findElements(By.className("xwiki-livetable")).isEmpty();
     }
 
     public ConfirmationPage clickDeleteAllEntries()

xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform-appwithinminutes-test/xwiki-platform-appwithinminutes-test-pageobjects/src/main/java/org/xwiki/appwithinminutes/test/po/ApplicationTemplateProviderEditPage.java

@@ -132,7 +132,7 @@ public String getTerminal()
 
     public boolean hasTerminalOption()
     {
-        return getDriver().findElementsWithoutWaiting(By.cssSelector("select#XWiki\\.TemplateProviderClass_0_terminal"))
-            .size() > 0;
+        return !getDriver()
+            .findElementsWithoutWaiting(By.cssSelector("select#XWiki\\.TemplateProviderClass_0_terminal")).isEmpty();
     }
 }