ci: fix yamllint issues in workflow updates

Made-with: Cursor

Author: yinkscss

.github/workflows/ci.yml

@@ -55,7 +55,8 @@ jobs:
           echo "Changed files:"
           echo "$CHANGED_FILES"
 
-          if echo "$CHANGED_FILES" | grep -Eq '^(Dockerfile|\.dockerignore|Cargo\.toml|Cargo\.lock|src/|config/|Makefile)'; then
+          DOCKER_PATTERN='^(Dockerfile|\.dockerignore|Cargo\.toml|Cargo\.lock|src/|config/|Makefile)'
+          if echo "$CHANGED_FILES" | grep -Eq "$DOCKER_PATTERN"; then
             echo "docker=true" >> "$GITHUB_OUTPUT"
           else
             echo "docker=false" >> "$GITHUB_OUTPUT"
@@ -67,7 +68,8 @@ jobs:
             echo "helm=false" >> "$GITHUB_OUTPUT"
           fi
 
-          if echo "$CHANGED_FILES" | grep -Eq '^(docs/|scripts/generate-api-docs\.py|config/crd/|src/crd/|src/rest_api/|Makefile)'; then
+          API_DOCS_PATTERN='^(docs/|scripts/generate-api-docs\.py|config/crd/|src/crd/|src/rest_api/|Makefile)'
+          if echo "$CHANGED_FILES" | grep -Eq "$API_DOCS_PATTERN"; then
             echo "api_docs=true" >> "$GITHUB_OUTPUT"
           else
             echo "api_docs=false" >> "$GITHUB_OUTPUT"
@@ -124,12 +126,14 @@ jobs:
           echo "stellar-operator version output: $BIN_VERSION"
 
           [[ "$CARGO_VERSION" == "$EXPECTED_VERSION" ]] || {
-            echo "::error::Cargo.toml version ($CARGO_VERSION) does not match expected release version ($EXPECTED_VERSION)"
+            echo "::error::Cargo.toml version ($CARGO_VERSION) does not match expected release version"
+            echo "::error::Expected: $EXPECTED_VERSION"
             exit 1
           }
 
           [[ "$BIN_VERSION" == "$EXPECTED_VERSION" ]] || {
-            echo "::error::stellar-operator version output ($BIN_VERSION) does not match expected release version ($EXPECTED_VERSION)"
+            echo "::error::stellar-operator version output ($BIN_VERSION) does not match expected release version"
+            echo "::error::Expected: $EXPECTED_VERSION"
             exit 1
           }
 

.github/workflows/pre-commit.yml

@@ -32,8 +32,10 @@ jobs:
       - name: Run pre-commit
         run: |
           if [[ "${{ github.event_name }}" == "pull_request" ]]; then
-            git fetch --no-tags origin "${{ github.event.pull_request.base.sha }}" "${{ github.event.pull_request.head.sha }}"
-            pre-commit run --from-ref "${{ github.event.pull_request.base.sha }}" --to-ref "${{ github.event.pull_request.head.sha }}" --show-diff-on-failure
+            BASE_SHA="${{ github.event.pull_request.base.sha }}"
+            HEAD_SHA="${{ github.event.pull_request.head.sha }}"
+            git fetch --no-tags origin "$BASE_SHA" "$HEAD_SHA"
+            pre-commit run --from-ref "$BASE_SHA" --to-ref "$HEAD_SHA" --show-diff-on-failure
           else
             pre-commit run --all-files --show-diff-on-failure
           fi

.github/workflows/verify-operator-boot.yml

@@ -1,4 +1,4 @@
-name: Verify Operator Boot (Issue #146)
+name: "Verify Operator Boot (Issue #146)"
 
 # Verifies that the operator binary builds and connects to a live kind cluster.
 # Acceptance criteria: