Skip to content

Commit bb74136

Browse files
committed
wip
1 parent e14855e commit bb74136

6 files changed

Lines changed: 15 additions & 9 deletions

File tree

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ gem 'jbuilder', '~> 2.0'
1111
gem 'jquery-rails'
1212
gem 'kramdown'
1313
gem 'materialize-sass'
14-
gem 'omniauth-slack'
14+
gem 'omniauth-slack', github: 'kmrshntr/omniauth-slack'
1515
gem 'pg'
1616
gem 'puma'
1717
gem 'react-rails'

Gemfile.lock

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,13 @@ GIT
88
minitest-metadata (~> 0.6)
99
minitest-rails (= 3.0.0.rc1)
1010

11+
GIT
12+
remote: git://github.com/kmrshntr/omniauth-slack.git
13+
revision: 8b2371150cf3d892750695cd88118f8b16db9d01
14+
specs:
15+
omniauth-slack (2.3.0)
16+
omniauth-oauth2 (~> 1.3.1)
17+
1118
GIT
1219
remote: https://github.com/5t111111/tapp.git
1320
revision: eba500b69d89a184d2382afe117a94a7ce562d37
@@ -157,8 +164,6 @@ GEM
157164
omniauth-oauth2 (1.3.1)
158165
oauth2 (~> 1.0)
159166
omniauth (~> 1.2)
160-
omniauth-slack (2.3.0)
161-
omniauth-oauth2 (~> 1.3.1)
162167
pg (0.18.4)
163168
pry (0.10.3)
164169
coderay (~> 1.1.0)
@@ -292,7 +297,7 @@ DEPENDENCIES
292297
materialize-sass
293298
minitest-rails-capybara!
294299
minitest-stub_any_instance
295-
omniauth-slack
300+
omniauth-slack!
296301
pg
297302
pry-byebug
298303
puma

app/controllers/sessions_controller.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ def new
99
def create
1010
auth = request.env['omniauth.auth']
1111

12-
binding.pry
13-
1412
unless User.team_member?(auth[:uid])
1513
return redirect_to login_url, alert: 'Only team member can login'
1614
end

app/models/concerns/authenticator.rb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,11 @@ def team_member?(uid)
77
end
88

99
def fetch_member_uids
10+
team_info = Slack::Web::Client.new.team_info
1011
users_list = Slack::Web::Client.new.users_list
11-
users_list.members.reject(&:deleted).map(&:id)
12+
users_list.members.reject(&:deleted).map(&:id).map do |uid|
13+
"#{uid}-#{team_info.team.id}"
14+
end
1215
end
1316
end
1417
end

app/models/user.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class User < ActiveRecord::Base
66
class << self
77
def find_or_create_from(auth)
88
find_or_create_by(provider: auth[:provider], uid: auth[:uid]) do |user|
9-
user.nickname = auth[:info][:nickname]
9+
user.nickname = auth[:info][:name]
1010
end
1111
end
1212
end

config/initializers/omniauth.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
provider :slack,
33
ENV['SLACK_CLIENT_ID'],
44
ENV['SLACK_CLIENT_SECRET'],
5-
scope: 'identity.basic,identity.team,identity.avatar'
5+
scope: 'identity.basic'
66

77
on_failure { |env| OmniAuth::FailureEndpoint.new(env).redirect_to_failure }
88
end

0 commit comments

Comments
 (0)