Commit 3015d87
authored
Fix some tab/group renaming bugs (warpdotdev#13261)
## Description
Fixes inline rename behavior in the vertical tabs panel:
• Clicking the panel's empty background now cancels an in-progress
tab/pane/group rename (previously the editor stayed open).
• In Panes view, double-click now renames the pane under the cursor (the
active pane) instead of the tab (this caused all panes to show rename
editor). Tabs/Summary view still renames the tab.
## Linked Issue
https://linear.app/warpdotdev/issue/APP-4806/rename-canceled-for-click-on-tab-panel
## Testing
<!--
How did you test this change? What automated tests did you add? If you
didn't add any new tests, what's your justification for not adding any?
Manual testing is required for changes that can be manually tested, and
almost all changes can be manually tested. If your change can be
manually tested, please include screenshots or a screen recording that
show it working end to end.
You can run the app locally using `./script/run` - see AGENTS.md for
more details on how to get set up.
-->
- [x] I have manually tested my changes locally with `./script/run`
### Screenshots / Videos
https://www.loom.com/share/e3ea82c9d481498590b34f5e62914f3b1 parent 9dcb9b8 commit 3015d87
3 files changed
Lines changed: 25 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
189 | 193 | | |
190 | 194 | | |
191 | 195 | | |
| |||
1136 | 1140 | | |
1137 | 1141 | | |
1138 | 1142 | | |
| 1143 | + | |
1139 | 1144 | | |
1140 | 1145 | | |
1141 | 1146 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23634 | 23634 | | |
23635 | 23635 | | |
23636 | 23636 | | |
| 23637 | + | |
| 23638 | + | |
| 23639 | + | |
| 23640 | + | |
| 23641 | + | |
23637 | 23642 | | |
23638 | 23643 | | |
23639 | 23644 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
402 | 402 | | |
403 | 403 | | |
404 | 404 | | |
405 | | - | |
| 405 | + | |
406 | 406 | | |
407 | 407 | | |
408 | 408 | | |
| |||
541 | 541 | | |
542 | 542 | | |
543 | 543 | | |
544 | | - | |
545 | | - | |
546 | | - | |
547 | | - | |
548 | | - | |
549 | 544 | | |
550 | 545 | | |
551 | 546 | | |
552 | 547 | | |
553 | | - | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
554 | 558 | | |
555 | | - | |
| 559 | + | |
556 | 560 | | |
557 | 561 | | |
558 | 562 | | |
| |||
1711 | 1715 | | |
1712 | 1716 | | |
1713 | 1717 | | |
| 1718 | + | |
| 1719 | + | |
| 1720 | + | |
1714 | 1721 | | |
1715 | 1722 | | |
1716 | 1723 | | |
| |||
0 commit comments