Commit a44b703
Fix team owner pill contrast (warpdotdev#11689)
## Testing
see before
[here](https://warpdev.slack.com/archives/C097ZGA1AMB/p1779809144889669?thread_ts=1779733378.222149&cid=C097ZGA1AMB)
and after:
### Cyber wave:
<img width="1728" height="1117" alt="image"
src="https://github.com/user-attachments/assets/abf10bd1-ff02-49fe-9920-be28a6f4b37c"
/>
### Willow dream
<img width="1728" height="1117" alt="image"
src="https://github.com/user-attachments/assets/0d776adf-71d4-4041-8b91-6fc6279b1616"
/>
###
<img width="1728" height="1117" alt="image"
src="https://github.com/user-attachments/assets/d997c0e7-d63b-4b63-8b87-67e98029c59c"
/>
## Description
Fixes the team settings owner pill contrast for themes where the accent
color/gradient is too close to the accent-tinted chip background,
including Cyber Wave, Willow Dream, and Solar Flare.
The owner chip previously used `theme.accent()` for the foreground and
`theme.accent().with_opacity(30)` for the background. This differed from
other theme-safe UI patterns that choose text color using theme contrast
helpers against the actual visible background. The fix keeps the
accent-tinted chip background and derives the text color with
`theme.main_text_color(...)` against the chip background composited over
the theme background.
## Linked Issue
Slack report in `#feedback-revenue`.
- [ ] The linked issue is labeled `ready-to-spec` or
`ready-to-implement`.
- [ ] Where appropriate, screenshots or a short video of the
implementation are included below (especially for user-visible or UI
changes).
## Testing
- `cargo fmt --manifest-path /workspace/warp/Cargo.toml --all --
--check`
- `cargo test --manifest-path /workspace/warp/Cargo.toml -p warp
test_owner_state_chip_text_contrasts_with_accent_overlay --lib`
- `cargo clippy --manifest-path /workspace/warp/Cargo.toml --workspace
--all-targets --all-features --tests -- -D warnings` (fails on
pre-existing `warpui_core` clippy diagnostics in
`crates/warpui_core/src/elements/{event_handler,hoverable,resizable,text}.rs`,
unrelated to this change)
- `cargo clippy --manifest-path /workspace/warp/Cargo.toml -p warp --lib
--tests -- -D warnings` (same pre-existing `warpui_core` diagnostics)
- [ ] I have manually tested my changes locally with `./script/run`
### Screenshots / Videos
Not included; this change is covered by a targeted contrast regression
test for Cyber Wave, Willow Dream, and Solar Flare.
## Agent Mode
- [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
CHANGELOG-BUG-FIX: Fixed the team settings owner badge being unreadable
on some themes.
_Conversation:
https://staging.warp.dev/conversation/052a8328-c4eb-480b-a98e-c16fe73498f1_
_Run:
https://oz.staging.warp.dev/runs/019e64e4-5de3-798c-b8ad-cff12af7d02f_
_This PR was generated with [Oz](https://warp.dev/oz)._
Co-authored-by: Oz <oz-agent@warp.dev>1 parent debe6d8 commit a44b703
1 file changed
Lines changed: 49 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| 108 | + | |
108 | 109 | | |
109 | 110 | | |
110 | 111 | | |
| |||
132 | 133 | | |
133 | 134 | | |
134 | 135 | | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
135 | 143 | | |
136 | 144 | | |
137 | 145 | | |
| |||
3502 | 3510 | | |
3503 | 3511 | | |
3504 | 3512 | | |
3505 | | - | |
3506 | | - | |
3507 | | - | |
3508 | | - | |
3509 | | - | |
3510 | | - | |
3511 | | - | |
3512 | | - | |
| 3513 | + | |
| 3514 | + | |
| 3515 | + | |
| 3516 | + | |
| 3517 | + | |
| 3518 | + | |
| 3519 | + | |
| 3520 | + | |
| 3521 | + | |
| 3522 | + | |
| 3523 | + | |
| 3524 | + | |
| 3525 | + | |
| 3526 | + | |
3513 | 3527 | | |
3514 | 3528 | | |
3515 | 3529 | | |
| |||
4424 | 4438 | | |
4425 | 4439 | | |
4426 | 4440 | | |
| 4441 | + | |
| 4442 | + | |
| 4443 | + | |
| 4444 | + | |
| 4445 | + | |
| 4446 | + | |
| 4447 | + | |
| 4448 | + | |
| 4449 | + | |
| 4450 | + | |
| 4451 | + | |
| 4452 | + | |
| 4453 | + | |
| 4454 | + | |
| 4455 | + | |
| 4456 | + | |
| 4457 | + | |
| 4458 | + | |
| 4459 | + | |
| 4460 | + | |
| 4461 | + | |
| 4462 | + | |
| 4463 | + | |
| 4464 | + | |
| 4465 | + | |
| 4466 | + | |
| 4467 | + | |
0 commit comments