Commit b2ebe0d
Fix agent tips not appearing below the warping indicator (warpdotdev#13122)
## Description
The rotating agent tips that normally render below the "Warping..." text
in Agent Mode stopped appearing.
**Root cause:** PR warpdotdev#9297 (commit `76cccd24d`, "Clip warping-indicator
chips so they don't overflow narrow panes") wrapped the warping
indicator's row in a `Clipped` element so the action chips don't
overflow into the adjacent pane on narrow widths. That row sits inside a
`ConstrainedBox` whose height was already fixed to a single line of
text. Before the clip was added, the tip rendered on a second line and
simply overflowed the fixed-height box visibly. Once the row was clipped
to the box's bounds, that second line — the agent tip (and the
fallback-model explanation, which uses the same `secondary_element`
slot) — was clipped away entirely.
**Fix:** In `render_warping_indicator_base`
(`app/src/ai/blocklist/block/view_impl/common.rs`), reserve room for the
secondary line in the footer height when a `secondary_element` is
present, so the clip no longer hides it while still clipping the chips
horizontally as intended. The height math is extracted into a small pure
helper `warping_footer_height(monospace_font_size,
has_secondary_element)`.
## Linked Issue
Reported in Slack (factory-client bug-triage): see thread link below. No
GitHub issue.
## Testing
- Added a regression unit test
`warping_footer_height_reserves_a_line_for_the_secondary_element` in
`common_tests.rs` that asserts the footer reserves an extra line
(secondary font size + 1px margin) when a secondary element is present.
It fails against the old single-line height and passes with the fix.
- `cargo nextest run -p warp warping_footer_height` — passes.
- `cargo clippy -p warp --lib --no-deps` — clean.
- **Manual UI verification (computer use) on a running debug build —
done.** Launched the authenticated `warp` build, started an agent, and
confirmed:
- Normal width: a tip line renders directly below `Warping...` (e.g.
`Tip: /new to start a new agent conversation with clean context. Learn
more`) and is fully visible, not clipped. Tips rotate as expected.
- Narrow pane: the tip still renders (horizontally ellipsized to fit)
and the action chips stay within the pane — i.e. warpdotdev#9297's chip-clipping
is preserved alongside the restored tip.
- Screenshots (normal + narrow width) are attached in the linked Slack
thread.
### Screenshots / Videos
Verification screenshots (normal-width tip restored; narrow-pane tip +
chips) are posted in the linked Slack thread below.
## Agent Mode
- [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
<!--
CHANGELOG-BUG-FIX: Fix the rotating agent tips not appearing below the
"Warping..." indicator in Agent Mode.
-->
CHANGELOG-BUG-FIX: Fix the rotating agent tips not appearing below the
"Warping..." indicator in Agent Mode.
_Slack thread:
https://warpdev.slack.com/archives/C0BCE7AELJ2/p1782518640801369?thread_ts=1782518640.801369&cid=C0BCE7AELJ2_
<!-- factory-client:
{"source":"factory-client","slack_channel":"C0BCE7AELJ2","slack_thread_ts":"1782518640.801369","slack_permalink":"https://warpdev.slack.com/archives/C0BCE7AELJ2/p1782518640801369?thread_ts=1782518640.801369&cid=C0BCE7AELJ2","oz_run_id":"019f0663-f881-7ce6-89b3-73c050689d53","repo":"warpdotdev/warp"}
-->
Co-authored-by: Oz <oz-agent@warp.dev>1 parent 11742b3 commit b2ebe0d
2 files changed
Lines changed: 47 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
526 | 526 | | |
527 | 527 | | |
528 | 528 | | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
529 | 546 | | |
530 | 547 | | |
531 | 548 | | |
| |||
543 | 560 | | |
544 | 561 | | |
545 | 562 | | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
546 | 567 | | |
547 | 568 | | |
548 | 569 | | |
| |||
646 | 667 | | |
647 | 668 | | |
648 | 669 | | |
649 | | - | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
650 | 674 | | |
651 | 675 | | |
652 | 676 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
| 20 | + | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
164 | 184 | | |
165 | 185 | | |
166 | 186 | | |
| |||
0 commit comments