Guard reset_chips reload in focus and repo-path updates (warpdotdev#12360)

Author: lucieleblanc

app/src/ai/blocklist/agent_view/agent_input_footer/chips.rs

@@ -25,8 +25,7 @@ impl AgentInputFooter {
                             .map(|v| v.to_string())
                             .unwrap_or_default()
                         || chip.chip_kind() != chip_result.kind()
-                        // For parity with PromptDisplay: compare the first on-click value only.
-                        || chip.first_on_click_value() != chip_result.on_click_values().first()
+                        || chip.on_click_values() != chip_result.on_click_values()
                 })
             })
     }

app/src/context_chips/display.rs

@@ -177,8 +177,7 @@ impl PromptDisplay {
                             .map(|v| v.to_string())
                             .unwrap_or_default()
                         || chip.chip_kind() != &chip_result.kind
-                        // I'm only comparing the first on-click values for efficiency, but we may need to change this in the future.
-                        || chip.first_on_click_value() != chip_result.on_click_values.first()
+                        || chip.on_click_values() != chip_result.on_click_values.as_slice()
                 })
             })
     }
@@ -290,7 +289,9 @@ impl PromptDisplay {
     pub fn on_pane_focus_changed(&mut self, focused: bool, ctx: &mut ViewContext<Self>) {
         self.pane_is_focused = focused;
         let new_chips = self.collect_chips(ctx);
-        self.reset_chips(&new_chips, ctx);
+        if self.check_if_chip_values_have_changed(&new_chips, ctx) {
+            self.reset_chips(&new_chips, ctx);
+        }
         ctx.notify();
     }
 
@@ -355,7 +356,9 @@ impl PromptDisplay {
     pub fn update_repo_path(&mut self, repo_path: Option<PathBuf>, ctx: &mut ViewContext<Self>) {
         self.current_repo_path = repo_path;
         let new_chips = self.collect_chips(ctx);
-        self.reset_chips(&new_chips, ctx);
+        if self.check_if_chip_values_have_changed(&new_chips, ctx) {
+            self.reset_chips(&new_chips, ctx);
+        }
         ctx.notify();
     }
 }

app/src/context_chips/display_chip.rs

@@ -289,7 +289,7 @@ pub struct DisplayChip {
     chip_kind: ContextChipKind,
     display_chip_kind: DisplayChipKind,
     next_chip_kind: Option<ContextChipKind>,
-    first_on_click_value: Option<String>,
+    on_click_values: Vec<String>,
     quota_reset_popup: ViewHandle<FeaturePopup>,
     session_context: Option<SessionContext>,
     menu_positioning_provider: Arc<dyn MenuPositioningProvider>,
@@ -887,7 +887,7 @@ impl DisplayChip {
             chip_kind: chip_result.kind,
             display_chip_kind,
             next_chip_kind,
-            first_on_click_value: chip_result.on_click_values.first().cloned(),
+            on_click_values: chip_result.on_click_values,
             quota_reset_popup,
             session_context: config.session_context,
             menu_positioning_provider: config.menu_positioning_provider,
@@ -927,8 +927,8 @@ impl DisplayChip {
         &self.display_chip_kind
     }
 
-    pub fn first_on_click_value(&self) -> Option<&String> {
-        self.first_on_click_value.as_ref()
+    pub(crate) fn on_click_values(&self) -> &[String] {
+        &self.on_click_values
     }
 
     pub fn close_git_branch_menu(&mut self, ctx: &mut ViewContext<Self>) {