Skip to content

Commit 0779434

Browse files
[Bug] Fixed query that fetches outdated versions (pimcore#18969)
* Fixed query that fetches outdated versions * Fix SQL query to use consistent formatting for active --------- Co-authored-by: JiaJia Ji <kingjia90@gmail.com>
1 parent 1c3925f commit 0779434

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

models/Version/Dao.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,11 +121,11 @@ public function maintenanceGetOutdatedVersions(array $elementTypes): array
121121
$tmpVersionIds = $this->db->fetchFirstColumn(
122122
'SELECT a.id as id FROM versions AS a
123123
LEFT JOIN schedule_tasks ON a.id = schedule_tasks.version
124-
LEFT JOIN '. $elementType['elementType'] .'s AS element ON sub.cid = element.id
125-
WHERE ctype = ?
124+
LEFT JOIN '. $elementType['elementType'] .'s AS element ON a.cid = element.id
125+
WHERE a.ctype = ?
126126
AND public = 0 AND autosave = 0
127127
AND element.modificationDate >= a.`date`
128-
AND `date` < ? AND AND IFNULL(active, 0) = 0',
128+
AND a.`date` < ? AND IFNULL(active, 0) = 0',
129129
[
130130
$elementType['elementType'],
131131
$deadline,
@@ -145,7 +145,7 @@ public function maintenanceGetOutdatedVersions(array $elementTypes): array
145145
) sub
146146
LEFT JOIN schedule_tasks ON sub.id = schedule_tasks.version
147147
LEFT JOIN '. $elementType['elementType'] .'s AS element ON sub.cid = element.id
148-
WHERE rownumber > ? AND IFNULL(active, 0) = 0 AND element.modificationDate >= sub.`date`
148+
WHERE rownumber > ? AND IFNULL(active, 0) = 0 AND element.modificationDate >= sub.`date`
149149
';
150150

151151
$iterator = $this->db->iterateAssociative(

0 commit comments

Comments
 (0)