Skip to content

Commit d720d58

Browse files
authored
[hotfix] Fix some typos for connector-base, protobuf, runtime, table-planner and tests modules. (apache#28328)
1 parent af30def commit d720d58

7 files changed

Lines changed: 13 additions & 13 deletions

File tree

flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceReader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ private void setCurrentReader(int index) {
223223
try {
224224
reader = source.createReader(readerContext);
225225
} catch (Exception e) {
226-
throw new RuntimeException("Failed tp create reader", e);
226+
throw new RuntimeException("Failed to create reader", e);
227227
}
228228
// currentReader must be switched before `addSplits` is called.
229229
currentSourceIndex = index;

flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/util/PbSchemaValidationUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ private static void validateTypeMatch(Descriptors.Descriptor descriptor, RowType
8383
throw new ValidationException(
8484
"Column "
8585
+ rowField.getName()
86-
+ " does not exists in definition of proto class.");
86+
+ " does not exist in definition of proto class.");
8787
}
8888
});
8989
}
@@ -160,7 +160,7 @@ private static void validateSimpleType(FieldDescriptor fd, LogicalTypeRoot logic
160160
throw new ValidationException(
161161
"Protobuf field type does not match column type, "
162162
+ fd.getJavaType()
163-
+ "(protobuf) is not compatible of "
163+
+ "(protobuf) is not compatible with "
164164
+ logicalTypeRoot);
165165
}
166166
}

flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/DefaultApplicationStore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ public void putApplication(ApplicationStoreEntry application) throws Exception {
210210
success = true;
211211
} catch (StateHandleStore.NotExistException ignored) {
212212
LOG.warn(
213-
"{} does not exists in {}.",
213+
"{} does not exist in {}.",
214214
application,
215215
applicationStateHandleStore);
216216
}

flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/DefaultExecutionPlanStore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ public void putExecutionPlan(ExecutionPlan executionPlan) throws Exception {
235235
success = true;
236236
} catch (StateHandleStore.NotExistException ignored) {
237237
LOG.warn(
238-
"{} does not exists in {}.",
238+
"{} does not exist in {}.",
239239
executionPlan,
240240
executionPlanStateHandleStore);
241241
}

flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/DynamicSinkUtils.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -515,7 +515,7 @@ private static RelNode convertUpdate(
515515
&& updateInfo.getRowLevelUpdateMode()
516516
!= SupportsRowLevelUpdate.RowLevelUpdateMode.ALL_ROWS) {
517517
throw new IllegalArgumentException(
518-
"Unknown update mode:" + updateInfo.getRowLevelUpdateMode());
518+
"Unknown update mode: " + updateInfo.getRowLevelUpdateMode());
519519
}
520520
Tuple2<RelNode, int[]> updateRelNodeAndRequireIndices =
521521
convertToRowLevelUpdate(
@@ -647,7 +647,7 @@ private static void convertPredicateToNegative(LogicalTableModify tableModify) {
647647
if (!(dynamicTableSource instanceof SupportsReadingMetadata)) {
648648
throw new UnsupportedOperationException(
649649
String.format(
650-
"The table source don't support reading metadata, but the require columns contains the meta columns: %s.",
650+
"The table source does not support reading metadata, but the required columns contain metadata columns: %s.",
651651
column));
652652
}
653653
// list what metas the source supports to read
@@ -661,7 +661,7 @@ private static void convertPredicateToNegative(LogicalTableModify tableModify) {
661661
if (!readableMetadata.containsKey(metaCol)) {
662662
throw new IllegalArgumentException(
663663
String.format(
664-
"Expect to read the meta column %s, but the table source for table %s doesn't support read the metadata column."
664+
"Expected to read metadata column %s, but the table source for table %s does not support it. "
665665
+ "Please make sure the readable metadata for the source contains %s.",
666666
column,
667667
UnresolvedIdentifier.of(
@@ -674,7 +674,7 @@ private static void convertPredicateToNegative(LogicalTableModify tableModify) {
674674
if (!dataType.equals(column.getDataType())) {
675675
throw new IllegalArgumentException(
676676
String.format(
677-
"Un-matched data type: the required column %s has datatype %s, but the data type in readable metadata for the table %s has data type %s. ",
677+
"Mismatched data type: the required column %s has data type %s, but readable metadata for table %s has data type %s.",
678678
column,
679679
column.getDataType(),
680680
UnresolvedIdentifier.of(

flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/IntervalJoinSpec.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@
2828
/**
2929
* IntervalJoinSpec describes how two tables will be joined in interval join.
3030
*
31-
* <p>This class corresponds to {@link org.apache.calcite.rel.core.Join} rel node. the join
32-
* condition is splitted into two part: WindowBounds and JoinSpec: 1. WindowBounds contains the time
33-
* range condition. 2. JoinSpec contains rest of the join condition except windowBounds.
31+
* <p>This class corresponds to {@link org.apache.calcite.rel.core.Join} rel node. The join
32+
* condition is splitted into two parts: WindowBounds and JoinSpec: 1. WindowBounds contains the
33+
* time range condition. 2. JoinSpec contains rest of the join condition except windowBounds.
3434
*/
3535
@JsonIgnoreProperties(ignoreUnknown = true)
3636
public class IntervalJoinSpec {

flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/GlobalAggregateITCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ void testExceptionThrowingAggregateFunction() throws Exception {
6363
/**
6464
* Source Function that uses updateGlobalAggregate() functionality exposed via
6565
* StreamingRuntimeContext to validate communication with JobMaster and test both failure and
66-
* sucess scenarios.
66+
* success scenarios.
6767
*/
6868
private static class TestSourceFunction extends RichSourceFunction<Integer> {
6969

0 commit comments

Comments
 (0)