perf: avoid redundant internal state snapshots

Author: dougle03

src/helpers/mustache.ts

@@ -32,13 +32,13 @@ function parseContext(key: string) {
 
 class CustomContext extends Context {
     readonly #nodeContext: NodeContext;
-    readonly #entities: HassEntities;
+    readonly #entities: Readonly<HassEntities>;
 
     constructor(
         view: any,
         parentContext: CustomContext | undefined,
         nodeContext: NodeContext,
-        entities: HassEntities,
+        entities: Readonly<HassEntities>,
     ) {
         super(view, parentContext);
         this.#nodeContext = nodeContext;
@@ -93,7 +93,7 @@ export function renderTemplate(
     str: string,
     message: NodeMessage,
     nodeContext: NodeContext,
-    entities: HassEntities,
+    entities: Readonly<HassEntities>,
     altTags = false,
 ): string {
     if (
@@ -115,7 +115,7 @@ export function renderTemplate(
 export function generateRenderTemplate(
     message: NodeMessage,
     context: NodeContext,
-    states: HassEntities,
+    states: Readonly<HassEntities>,
 ) {
     return (template: string, altTags = false) =>
         renderTemplate(template, message, context, states, altTags);

src/homeAssistant/Websocket.ts

@@ -716,6 +716,15 @@ export default class Websocket {
         return cloneDeep(this.states);
     }
 
+    /**
+     * Return the current state map for internal read-only consumers.
+     * Callers must not modify the returned object. Use getStates() when an
+     * independent snapshot is required.
+     */
+    getStatesReadOnly(): Readonly<HassEntities> {
+        return this.states;
+    }
+
     getState(entityId: string): HassEntity | undefined {
         return cloneDeep(this.states[entityId]);
     }

src/nodes/action/ActionController.ts

@@ -37,7 +37,7 @@ export default class ActionController extends InputOutputController<
             throw new NoConnectionError();
         }
 
-        const states = this.homeAssistant.websocket.getStates();
+        const states = this.homeAssistant.websocket.getStatesReadOnly();
 
         const render = generateRenderTemplate(
             message,
@@ -245,7 +245,7 @@ export default class ActionController extends InputOutputController<
         const render = generateRenderTemplate(
             message,
             this.node.context(),
-            this.homeAssistant.websocket.getStates(),
+            this.homeAssistant.websocket.getStatesReadOnly(),
         );
 
         const map: Record<string, string> = {

src/nodes/api/ApiController.ts

@@ -26,7 +26,7 @@ export default class ApiController extends InputOutputController<
         const renderTemplate = generateRenderTemplate(
             message,
             this.node.context(),
-            this.homeAssistant.websocket.getStates(),
+            this.homeAssistant.websocket.getStatesReadOnly(),
         );
 
         let data;

src/nodes/current-state/CurrentStateController.ts

@@ -47,7 +47,7 @@ export default class CurrentStateController extends InputOutputController<
             parsedMessage.entityId.value,
             message,
             this.node.context(),
-            this.#homeAssistant.websocket.getStates(),
+            this.#homeAssistant.websocket.getStatesReadOnly(),
         );
 
         const entity = this.#homeAssistant.websocket.getState(

src/nodes/fire-event/FireEventController.ts

@@ -28,7 +28,7 @@ export default class FireEventController extends InputOutputController<
                       parsedMessage.event.value,
                       message,
                       this.node.context(),
-                      this.homeAssistant.websocket.getStates(),
+                      this.homeAssistant.websocket.getStatesReadOnly(),
                   );
 
         let eventData: unknown;
@@ -49,7 +49,7 @@ export default class FireEventController extends InputOutputController<
                         : parsedMessage.data.value,
                     message,
                     this.node.context(),
-                    this.homeAssistant.websocket.getStates(),
+                      this.homeAssistant.websocket.getStatesReadOnly(),
                 );
                 try {
                     eventData = JSON.parse(dataString);

src/nodes/get-entities/GetEntitiesController.ts

@@ -150,7 +150,7 @@ export default class GetEntitiesController extends SendSplitController {
     ): Promise<HassEntity[]> {
         const currentTime = Date.now();
         const filteredEntities: HassEntity[] = [];
-        const states = this.#homeAssistant.websocket.getStates();
+        const states = this.#homeAssistant.websocket.getStatesReadOnly();
         const sortedConditions = sortConditions(conditions);
 
         const stateKeys = Object.keys(states);

src/nodes/get-history/GetHistoryController.ts

@@ -39,12 +39,12 @@ export default class GetHistoryController extends SendSplitController {
                 parsedMessage.entityId.value,
                 message,
                 this.node.context(),
-                this.homeAssistant.websocket.getStates(),
+                this.homeAssistant.websocket.getStatesReadOnly(),
             );
         }
         if (parsedMessage.entityIdType.value === EntityFilterType.Regex) {
             const entities = Object.keys(
-                this.homeAssistant.websocket.getStates(),
+                this.homeAssistant.websocket.getStatesReadOnly(),
             );
             const regex = new RegExp(entityId);
             entityId = entities

src/nodes/tag/issue-check.ts

@@ -12,7 +12,7 @@ export default function issueCheck(config: TagNodeProperties): Issue[] {
     if (!ha) {
         return issues;
     }
-    const states = ha.websocket.getStates();
+    const states = ha.websocket.getStatesReadOnly();
     const tagStates = Object.values(states).filter((state) =>
         state.entity_id.startsWith('tag.'),
     );

src/nodes/trigger-state/TriggerStateController.ts

@@ -288,7 +288,7 @@ export default class TriggerStateController extends ExposeAsController {
                     output.messageValue,
                     eventMessage.event as NodeMessage,
                     this.node.context(),
-                    this.homeAssistant.websocket.getStates(),
+                    this.homeAssistant.websocket.getStatesReadOnly(),
                 );
             }