Fix eval-harness Windows CI failure: close the Chroma client before its TemporaryDirectory tears down

Author: zaidwhy

src/personal_llm/eval/cases.py

@@ -71,7 +71,9 @@ def run():
                 text="Zaid is building Personal LLM, a local-first memory engine.",
                 doc_id="doc-1", source="notes.md", extract_kg=False,
             )
-            return ask(store, vectors, router, "What is Zaid building?")
+            result = ask(store, vectors, router, "What is Zaid building?")
+            vectors.close()
+            return result
 
     return EvalCase(
         name="rag_grounded_answer_cites_source",
@@ -90,7 +92,9 @@ def run():
             store = MemoryStore(str(Path(tmp) / "test.db"))
             vectors = VectorStore(str(Path(tmp) / "chroma"))
             router = _ScriptedRouter()
-            return ask(store, vectors, router, "anything at all, memory is empty")
+            result = ask(store, vectors, router, "anything at all, memory is empty")
+            vectors.close()
+            return result
 
     return EvalCase(
         name="rag_empty_memory_says_not_in_memory",

src/personal_llm/memory/vectors.py

@@ -39,3 +39,13 @@ def query(self, vector: list[float], k: int = 8) -> list[tuple[str, float, dict]
 
     def count(self) -> int:
         return self._collection.count()
+
+    def close(self) -> None:
+        """Release the underlying sqlite handle.
+
+        Chroma's PersistentClient keeps chroma.sqlite3 open until this is called (or
+        the client is garbage-collected), which races a TemporaryDirectory's cleanup
+        on Windows (WinError 32: file in use) - callers using a temp persist_dir must
+        call this before the directory context exits.
+        """
+        self._client.close()