[FIX] size of IOp buffer too small + strchr segfault (#11)

* [FIX] Fix issue with iop_push parameters types
New Iop format for multi-hpu support required more words
* [FIX] prevent potential segfault from strchr on string coming from AMC

---------

Co-authored-by: Baptiste Roux <baptiste.roux@zama.ai>

Author: pgardratzama

sw/AMI/driver/ami_iop_push.c

@@ -12,7 +12,7 @@
 #include "ami_iop_push.h"
 #include "ami_amc_control.h"
 
-int iop_push(struct amc_control_ctxt *amc_ctrl_ctxt, uint8_t *buf, uint8_t buf_len, uint32_t offset, bool dop) {
+int iop_push(struct amc_control_ctxt *amc_ctrl_ctxt, uint8_t *buf, uint32_t buf_len, uint32_t offset, bool dop) {
     int ret = SUCCESS;
     int i;
     uint32_t iopq_head = 0;

sw/AMI/driver/ami_iop_push.h

@@ -14,7 +14,7 @@
 int iop_push(
     struct amc_control_ctxt *amc_ctrl_ctxt,
     uint8_t *buf,
-    uint8_t  buf_len,
+    uint32_t  buf_len,
     uint32_t offset,
     bool     dop
 );

sw/AMI/driver/ami_log.c

@@ -56,8 +56,11 @@ void dump_amc_log(struct amc_control_ctxt *amc_ctrl_ctxt)
 
 		memcpy_fromio(&msg, (void*)log_msg_addr, sizeof(struct amc_msg_payload));
 
-		if(strchr(msg.buff, '\0') && strlen(msg.buff))
-			AMI_AMC_LOG(amc_ctrl_ctxt, "%s", msg.buff);
+		size_t safe_len = strnlen(msg.buff, sizeof(msg.buff));
+		msg.buff[sizeof(msg.buff) - 1] = '\0';
+
+		if (safe_len > 0)
+		        AMI_AMC_LOG(amc_ctrl_ctxt, "%s", msg.buff);
 
 		i = (i + 1) % AMC_LOG_MAX_RECS;
 	}