|
10 | 10 | 0 errors | 0 warnings | 1 note |
11 | 11 |
|
12 | 12 | * NOTE: Installed package size is 9.2Mb. |
13 | | - Justification: The installed size is primarily driven by the `libs` directory (~8.0Mb). This is expected and due to the heavy C++ template metaprogramming from `RcppEigen` used in the core mathematical engine. |
14 | | - |
15 | | -## Reverse dependencies |
16 | | -I have checked 0 reverse dependencies and found no issues. |
17 | | - |
18 | | ---- |
| 13 | + The installed size is primarily driven by the `libs` directory (~8.0Mb) due to `RcppEigen`-based C++ code. |
19 | 14 |
|
20 | 15 | ## Submission Summary |
21 | | -This is a resubmission to address the CRAN check failures reported in version 2.0.0 (requested to be fixed by 2026-03-16). |
22 | | - |
23 | | -**Fixes for CRAN:** |
24 | | -* **Fixed ERROR on macOS ARM64 (r-oldrel-macos-arm64):** Fixed the `invalid comparison with complex values` testing error in `ppg_esim`. The `eigen()` function returned tiny imaginary parts on macOS ARM64 for non-symmetric matrices; we now wrap the values in `Re()` before rank evaluation. |
25 | | -* **Fixed WARNING and NOTE regarding non-standard and non-portable files:** Removed non-portable `.mhtml` files and updated `.Rbuildignore` to properly exclude development log files (`.txt` and `.mhtml`) from the top-level package bundle. |
| 16 | +This is a resubmission to address CRAN check findings from version 2.0.0. |
26 | 17 |
|
27 | | -**Other Enhancements in 2.0.1:** |
28 | | -* **Expanded CI Coverage:** Integrated a comprehensive 15-runner GitHub Actions matrix mirroring all official CRAN check flavors including explicit ARM64 support for macOS, Windows, and Linux. |
29 | | -* **Documentation:** Automated spell-checking integrated into the CI pipeline via the `spelling` package. |
| 18 | +Changes made: |
| 19 | +* Fixed macOS ARM64 test error (`invalid comparison with complex values`) in `ppg_esim` by using `Re()` on eigenvalues before rank checks. |
| 20 | +* Removed non-portable `.mhtml` files and updated `.Rbuildignore` to exclude development log files (`.txt`, `.mhtml`). |
| 21 | +* Updated string-matching tests to use explicit matching (`fixed = TRUE` or `perl = TRUE`) and kept `skip_on_cran()` in CRAN-sensitive heavy/error-handling tests. |
| 22 | +* Removed unused C++ variable in `src/math_primitives.cpp` (`min_group`) to resolve strict compiler warning checks. |
| 23 | +* Corrected test setup in `tests/testthat/test-design_stats.R` for invalid `design_type` test input initialization. |
30 | 24 |
|
31 | | -Thank you to the CRAN team for reviewing this update. |
| 25 | +rchk note: |
| 26 | +* Reports referencing `Rcpp` internal headers (`Armor.h` / `Shield.h`) were reviewed; no corresponding memory-protection issue was identified in package source files. |
0 commit comments