perf: pool ghost download buffers without type collisions

Author: wopian

Ghosting/Playback/GhostRepository.cs

@@ -1,3 +1,5 @@
+extern alias BuffersAlias;
+
 using System;
 using System.Collections.Generic;
 using System.IO;
@@ -225,11 +227,18 @@ private static async Task<byte[]> ReadLimitedAsync(HttpContent content, Cancella
     {
         using Stream input = await content.ReadAsStreamAsync();
         using LimitedMemoryStream output = new(GhostLimits.MaxCompressedBytes);
-        byte[] copyBuffer = new byte[81_920];
-        int read;
-        while ((read = await input.ReadAsync(copyBuffer, 0, copyBuffer.Length, cancellationToken)) > 0)
-            output.Write(copyBuffer, 0, read);
-        return output.ToArray();
+        byte[] copyBuffer = BuffersAlias::System.Buffers.ArrayPool<byte>.Shared.Rent(81_920);
+        try
+        {
+            int read;
+            while ((read = await input.ReadAsync(copyBuffer, 0, copyBuffer.Length, cancellationToken)) > 0)
+                output.Write(copyBuffer, 0, read);
+            return output.ToArray();
+        }
+        finally
+        {
+            BuffersAlias::System.Buffers.ArrayPool<byte>.Shared.Return(copyBuffer);
+        }
     }
 
     private static string GetStorageKey(int recordId) => "ghosts/" + recordId;

Zeepkist.GTR.Mod.csproj

@@ -45,6 +45,7 @@
         <PackageReference Include="Serilog.Extensions.Hosting" Version="8.0.0" />
         <PackageReference Include="Serilog.Sinks.Console" Version="6.0.0" />
         <PackageReference Include="StrawberryShake.Transport.Http" Version="14.3.0" />
+        <PackageReference Include="System.Buffers" Version="4.6.1" Aliases="BuffersAlias" />
         <PackageReference Include="Zeepkist.GameLibs" Version="17.15.1867" PrivateAssets="all" />
         <PackageReference Include="ZeepSDK" Version="2.5.0" PrivateAssets="all" />
     </ItemGroup>