Skip to content

Commit 80bfd76

Browse files
committed
fix npu finetune bug
1 parent 031042c commit 80bfd76

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

dnallm/configuration/configs.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,7 @@ class TrainingConfig(BaseModel):
290290
seed: int = 42
291291
bf16: bool = False
292292
fp16: bool = False
293+
gradient_checkpointing: bool = False
293294
load_best_model_at_end: bool = False
294295
metric_for_best_model: str = "eval_loss"
295296
report_to: list[str] = Field(

dnallm/finetune/trainer.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@ def set_up_trainer(self):
193193
training_args.pop("hyperparameter_search", None)
194194
training_args.pop("use_qlora", None)
195195
training_args.pop("quantization_config", None)
196+
self._save_safetensors = training_args.pop("save_safetensors", True)
196197
self.training_args = TrainingArguments(
197198
**training_args,
198199
)
@@ -379,7 +380,7 @@ def train(self, save_tokenizer: bool = True) -> dict[str, float]:
379380
if hasattr(self.model, "save_pretrained"):
380381
self.model.save_pretrained(
381382
self.train_config.output_dir,
382-
safe_serialization=self.trainer.args.save_safetensors,
383+
safe_serialization=self._save_safetensors,
383384
)
384385
if save_tokenizer:
385386
self.datasets.tokenizer.save_pretrained(self.train_config.output_dir) # type: ignore
@@ -433,7 +434,7 @@ def search(self, save_tokenizer: bool = True) -> dict[str, Any]:
433434
if hasattr(self.model, "save_pretrained"):
434435
self.model.save_pretrained(
435436
self.train_config.output_dir,
436-
safe_serialization=self.trainer.args.save_safetensors,
437+
safe_serialization=self._save_safetensors,
437438
)
438439
if save_tokenizer:
439440
self.datasets.tokenizer.save_pretrained(self.train_config.output_dir) # type: ignore

0 commit comments

Comments
 (0)