Fix resolved type of pointer to const array element

Author: FnControlOption

src/analysis.zig

@@ -1785,15 +1785,6 @@ fn resolveTypeOfNodeUncached(analyser: *Analyser, node_handle: NodeWithHandle) e
 
             return try analyser.resolveOptionalUnwrap(base_type);
         },
-        .array_access => {
-            const lhs_node, const rhs_node = tree.nodeData(node).node_and_node;
-
-            const lhs = try analyser.resolveTypeOfNodeInternal(.of(lhs_node, handle)) orelse return null;
-
-            const index = try analyser.resolveIntegerLiteral(u64, .of(rhs_node, handle));
-
-            return try analyser.resolveBracketAccessType(lhs, .{ .single = index });
-        },
         .@"orelse" => {
             const lhs_node, const rhs_node = tree.nodeData(node).node_and_node;
 
@@ -2725,6 +2716,7 @@ fn resolveTypeOfNodeUncached(analyser: *Analyser, node_handle: NodeWithHandle) e
         .slice,
         .slice_sentinel,
         .slice_open,
+        .array_access,
         => {
             const binding = try analyser.resolveBindingOfNodeUncached(node_handle) orelse return null;
             return binding.type;
@@ -2818,6 +2810,19 @@ fn resolveBindingOfNodeUncached(analyser: *Analyser, node_handle: NodeWithHandle
             };
         },
 
+        .array_access => {
+            const lhs_node, const rhs_node = tree.nodeData(node).node_and_node;
+
+            const lhs = try analyser.resolveBindingOfNodeInternal(.of(lhs_node, handle)) orelse return null;
+
+            const index = try analyser.resolveIntegerLiteral(u64, .of(rhs_node, handle));
+
+            return .{
+                .type = try analyser.resolveBracketAccessTypeFromBinding(lhs, .{ .single = index }) orelse return null,
+                .is_const = true,
+            };
+        },
+
         else => return .{
             .type = try analyser.resolveTypeOfNodeUncached(node_handle) orelse return null,
             .is_const = false,

tests/analysis/array.zig

@@ -32,6 +32,9 @@ const some_unsized_array_len = some_unsized_array.len;
 const array_indexing = some_array[0];
 //    ^^^^^^^^^^^^^^ (u8)()
 
+const array_indexing_pointer = &some_array[0];
+//    ^^^^^^^^^^^^^^^^^^^^^^ (*const u8)()
+
 const array_slice_open_1 = some_array[1..];
 //    ^^^^^^^^^^^^^^^^^^ (*const [2]u8)()