move variable naming checks to diagnostics.zig

Author: Techatrix

src/analysis.zig

@@ -655,20 +655,6 @@ pub fn isTypeFunction(tree: *const Ast, func: Ast.full.FnProto) bool {
     return isMetaType(tree, return_type);
 }
 
-// STYLE
-
-pub fn isCamelCase(name: []const u8) bool {
-    return !std.ascii.isUpper(name[0]) and !isSnakeCase(name);
-}
-
-pub fn isPascalCase(name: []const u8) bool {
-    return std.ascii.isUpper(name[0]) and !isSnakeCase(name);
-}
-
-pub fn isSnakeCase(name: []const u8) bool {
-    return std.mem.find(u8, name, "_") != null;
-}
-
 // ANALYSIS ENGINE
 
 /// Resolves variable declarations consisting of chains of imports and field accesses of containers

src/features/diagnostics.zig

@@ -206,15 +206,15 @@ fn collectWarnStyleDiagnostics(
                         const is_type_function = Analyser.isTypeFunction(tree, func);
 
                         const func_name = tree.tokenSlice(name_token);
-                        if (!is_type_function and !Analyser.isCamelCase(func_name)) {
+                        if (!is_type_function and !isCamelCase(func_name)) {
                             try diagnostics.append(arena, .{
                                 .range = offsets.tokenToRange(tree, name_token, offset_encoding),
                                 .severity = .Hint,
                                 .code = .{ .string = "bad_style" },
                                 .source = "zls",
                                 .message = "Functions should be camelCase",
                             });
-                        } else if (is_type_function and !Analyser.isPascalCase(func_name)) {
+                        } else if (is_type_function and !isPascalCase(func_name)) {
                             try diagnostics.append(arena, .{
                                 .range = offsets.tokenToRange(tree, name_token, offset_encoding),
                                 .severity = .Hint,
@@ -231,6 +231,18 @@ fn collectWarnStyleDiagnostics(
     }
 }
 
+fn isCamelCase(name: []const u8) bool {
+    return !std.ascii.isUpper(name[0]) and !isSnakeCase(name);
+}
+
+fn isPascalCase(name: []const u8) bool {
+    return std.ascii.isUpper(name[0]) and !isSnakeCase(name);
+}
+
+fn isSnakeCase(name: []const u8) bool {
+    return std.mem.find(u8, name, "_") != null;
+}
+
 fn collectGlobalVarDiagnostics(
     tree: *const Ast,
     arena: std.mem.Allocator,