feat: add new property into ViewModel

Author: zigzagdev

src/app/Packages/Features/QueryUseCases/Factory/ViewModel/WorldHeritageDetailViewModelFactory.php

@@ -10,11 +10,12 @@ class WorldHeritageDetailViewModelFactory
 {
     public static function build(WorldHeritageDto $dto): array
     {
+
         return [
             'id' => $dto->getId(),
             'official_name' => $dto->getOfficialName(),
             'name' => $dto->getName(),
-            'name_jp' => $dto->getNameJp(),
+            'name_jp' => $dto->getCountryNameJp(),
             'country' => $dto->getCountry(),
             'region' => $dto->getRegion(),
             'category' => $dto->getCategory(),
@@ -27,6 +28,7 @@ public static function build(WorldHeritageDto $dto): array
             'longitude' => $dto->getLongitude(),
             'short_description' => $dto->getShortDescription(),
             'unesco_site_url' => $dto->getUnescoSiteUrl(),
+            'short_description_jp' => $dto->getShortDescriptionJp(),
             'state_party' => $dto->getStateParty(),
             'state_party_codes' => $dto->getStatePartyCodes(),
             'state_parties_meta' => $dto->getStatePartiesMeta(),

src/app/Packages/Features/QueryUseCases/Tests/ViewModel/WorldHeritageDetailViewModelFactoryTest.php

@@ -38,6 +38,7 @@ private function arrayData(): array
             'latitude' => 0.0,
             'longitude' => 0.0,
             'short_description' => 'Transnational serial property of European beech forests illustrating post-glacial expansion and ecological processes across Europe.',
+            'short_description_jp' => 'あいうえお',
             'unesco_site_url' => 'https://whc.unesco.org/en/list/1133/',
             'state_parties' => [
                 'ALB','AUT','BEL','BIH','BGR','HRV','CZE','FRA','DEU','ITA','MKD','POL','ROU','SVK','SVN','ESP','CHE','UKR'
@@ -149,6 +150,10 @@ private function mockDto(): WorldHeritageDto
             ->shouldReceive('getShortDescription')
             ->andReturn($this->arrayData()['short_description']);
 
+        $dto
+            ->shouldReceive('getShortDescriptionJp')
+            ->andReturn($this->arrayData()['short_description_jp']);
+
         $dto
             ->shouldReceive('getUnescoSiteUrl')
             ->andReturn($this->arrayData()['unesco_site_url']);

src/app/Packages/Features/QueryUseCases/Tests/ViewModel/WorldHeritageSummaryViewModelFactoryTest.php

@@ -41,6 +41,7 @@ private function arrayData(): array
                 'latitude' => 0.0,
                 'longitude' => 0.0,
                 'short_description' => '氷期後のブナの自然拡散史を示すヨーロッパ各地の原生的ブナ林群から成る越境・連続資産。',
+                'short_description_jp' => 'あいうえお',
                 'unesco_site_url' => 'https://whc.unesco.org/en/list/1133',
                 'thumbnail_url' => 'https://example.com/thumbnail.jpg',
                 'state_parties_codes' => [
@@ -146,6 +147,9 @@ private function mockDto(): WorldHeritageDto
         $mock->shouldReceive('getCountryNameJp')
             ->andReturn($this->arrayData()['country_name_jp']);
 
+        $mock->shouldReceive('getShortDescriptionJp')
+            ->andReturn($this->arrayData()['short_description_jp']);
+
         $mock->shouldReceive('getPrimaryStatePartyCode')
             ->andReturn($this->arrayData()['state_parties_codes'][4]);
 
@@ -198,6 +202,7 @@ public function test_check_view_model_value(): void
         $this->assertEquals($this->arrayData()['area_hectares'], $resultArray['area_hectares']);
         $this->assertEquals($this->arrayData()['buffer_zone_hectares'], $resultArray['buffer_zone_hectares']);
         $this->assertEquals($this->arrayData()['short_description'], $resultArray['short_description']);
+        $this->assertEquals($this->arrayData()['short_description_jp'], $resultArray['short_description_jp']);
         $this->assertEquals($this->arrayData()['state_parties_codes'], $resultArray['state_party_codes']);
         $this->assertEquals($this->arrayData()['state_parties_meta'], $resultArray['state_parties_meta']);
         $this->assertEquals($this->arrayData()['thumbnail_url'], $resultArray['thumbnail_url']);

src/app/Packages/Features/QueryUseCases/Tests/ViewModel/WorldHeritageViewModelCollectionFactoryTest.php

@@ -42,6 +42,7 @@ private function arrayData(): array
                 'latitude' => 0.0,
                 'longitude' => 0.0,
                 'short_description' => 'Transnational serial property of European beech forests illustrating post-glacial expansion and ecological processes across Europe.',
+                'short_description_jp' => 'あいうえお',
                 'thumbnail_url' => 'https://example.com/en/list/1133/',
                 'unesco_site_url' => 'https://whc.unesco.org/en/list/1133/',
                 'state_parties' => [
@@ -86,6 +87,7 @@ private function arrayData(): array
                 'latitude' => 0.0,
                 'longitude' => 0.0,
                 'short_description' => 'Transnational Silk Road corridor across China, Kazakhstan and Kyrgyzstan illustrating exchange of goods, ideas and beliefs.',
+                'short_description_jp' => 'あいうえお',
                 'thumbnail_url' => 'https://example.com/en/list/1442/',
                 'unesco_site_url' => 'https://whc.unesco.org/en/list/1442/',
                 'state_parties' => ['CN','KZ','KG'],
@@ -131,6 +133,7 @@ private function mockDtoCollection(): WorldHeritageDtoCollection
                 images: null,
                 imageUrl: $thumbnail,
                 unescoSiteUrl: $data['unesco_site_url'] ?? null,
+                shortDescriptionJp: $data['short_description_jp'] ?? null,
                 statePartyCodes: $data['state_party_codes'] ?? ($data['state_parties'] ?? []),
                 statePartiesMeta: $data['state_parties_meta'] ?? []
             );
@@ -178,6 +181,7 @@ public function test_view_model_collection_check_value(): void
             $this->assertEquals($this->arrayData()[$key]['latitude'], $value['latitude']);
             $this->assertEquals($this->arrayData()[$key]['longitude'], $value['longitude']);
             $this->assertEquals($this->arrayData()[$key]['short_description'], $value['short_description']);
+            $this->assertEquals($this->arrayData()[$key]['short_description_jp'], $value['short_description_jp']);
             $this->assertEquals($this->arrayData()[$key]['thumbnail_url'], $value['thumbnail_url']);
             $this->assertSame($expectedCodes, $value['state_party_codes']);
             $this->assertEquals($this->arrayData()[$key]['state_parties_meta'], $value['state_parties_meta']);

src/app/Packages/Features/QueryUseCases/ViewModel/WorldHeritageViewModel.php

@@ -125,6 +125,11 @@ public function getImages(): array
         return $this->dto->getImages();
     }
 
+    public function getShortDescriptionJp(): ?string
+    {
+        return $this->dto->getShortDescriptionJp();
+    }
+
     public function toArray(): array
     {
         return [
@@ -146,6 +151,7 @@ public function toArray(): array
             'buffer_zone_hectares' => $this->getBufferZoneHectares(),
             'short_description' => $this->getShortDescription(),
             'unesco_site_url' => $this->getUnescoSiteUrl(),
+            'short_description_jp' => $this->getShortDescriptionJp(),
             'state_party_codes' => $this->getStatePartyCodes(),
             'state_parties_meta' => $this->getStatePartiesMeta(),
             'primary_state_party_code' => $this->getPrimaryStatePartyCode(),