Merge pull request #432 from zigzagdev/fix/command-translation-refactor

refactor: Translation API fetching Command

Author: zigzagdev

src/app/Console/Commands/TranslateShortDescriptionJapanese.php

@@ -23,7 +23,7 @@ class TranslateShortDescriptionJapanese extends Command
      *
      * @var string
      */
-    protected $description = 'Command description';
+    protected $description = 'Translate UNESCO world heritage short_description and description into Japanese, and persist them into world_heritage_descriptions.';
 
     /**
      * Execute the console command.
@@ -102,20 +102,15 @@ public function handle(): int
                 $shortDescriptionJa = $translated['short_description_ja'] ?? null;
                 $descriptionJa      = $translated['description_ja'] ?? null;
 
-                if (!$this->option('dry-run')) {
-                    WorldHeritageDescription::updateOrCreate(
-                        ['world_heritage_site_id' => $idNo],
-                        [
-                            'short_description_en' => $shortDescriptionEn,
-                            'short_description_ja' => $shortDescriptionJa,
-                            'description_en'       => $descriptionEn,
-                            'description_ja'       => $descriptionJa,
-                        ]
-                    );
-                }
-
-                $sites[$index]['short_description_ja'] = $shortDescriptionJa;
-                $sites[$index]['description_ja']       = $descriptionJa;
+                $this->persistTranslation(
+                    $idNo,
+                    $shortDescriptionEn,
+                    $shortDescriptionJa,
+                    $descriptionEn,
+                    $descriptionJa,
+                    $sites,
+                    $index,
+                );
                 $bar->advance();
                 continue;
             }
@@ -151,19 +146,16 @@ public function handle(): int
                 ? $shortDescriptionJa
                 : $translations[1]['translatedText'];
 
-            WorldHeritageDescription::updateOrCreate(
-                ['world_heritage_site_id' => $idNo],
-                [
-                    'short_description_en' => $shortDescriptionEn,
-                    'short_description_ja' => $shortDescriptionJa,
-                    'description_en'       => $descriptionEn,
-                    'description_ja'       => $descriptionJa,
-                ]
+            $this->persistTranslation(
+                $idNo,
+                $shortDescriptionEn,
+                $shortDescriptionJa,
+                $descriptionEn,
+                $descriptionJa,
+                $sites,
+                $index,
             );
 
-            $sites[$index]['short_description_ja'] = $shortDescriptionJa;
-            $sites[$index]['description_ja']       = $descriptionJa;
-
             $bar->advance();
             usleep(200000);
         }
@@ -189,4 +181,29 @@ public function handle(): int
 
         return 0;
     }
+
+    private function persistTranslation(
+        $idNo,
+        string $shortDescriptionEn,
+        ?string $shortDescriptionJa,
+        string $descriptionEn,
+        ?string $descriptionJa,
+        array &$sites,
+        int $index,
+    ): void {
+        if (!$this->option('dry-run')) {
+            WorldHeritageDescription::updateOrCreate(
+                ['world_heritage_site_id' => $idNo],
+                [
+                    'short_description_en' => $shortDescriptionEn,
+                    'short_description_ja' => $shortDescriptionJa,
+                    'description_en'       => $descriptionEn,
+                    'description_ja'       => $descriptionJa,
+                ]
+            );
+        }
+
+        $sites[$index]['short_description_ja'] = $shortDescriptionJa;
+        $sites[$index]['description_ja']       = $descriptionJa;
+    }
 }