Add comprehensive diagnostic logging to SingleNodeExecutor to try to understand where the deadlock comes from#1137
Draft
Add comprehensive diagnostic logging to SingleNodeExecutor to try to understand where the deadlock comes from#1137
SingleNodeExecutor to try to understand where the deadlock comes from#1137Conversation
This adds detailed logging to help identify where deadlocks occur in the Redis client.
Each promise gets a unique ID to track its full lifecycle from creation to completion.
Logging added:
- Promise lifecycle: creation, queueing, completion/failure with unique IDs
- Queue state tracking: requests and responses queue sizes throughout operations
- Send operations: request processing, connection writes, promise movement to response queue
- Receive operations: response processing, promise completion
- Error handling: detailed error scenarios and promise cleanup
- Runner fiber: send/receive fiber lifecycle and failure/retry scenarios
Log prefixes:
- [REDIS-INIT]: Executor initialization
- [REDIS-EXEC-{id}]: Individual request/promise lifecycle
- [REDIS-SEND]: Send fiber operations
- [REDIS-RECV]: Receive fiber operations
- [REDIS-ERROR]: Error handling scenarios
- [REDIS-RUNNER]: Runner fiber lifecycle
This will help identify deadlock scenarios in CI environments by showing:
1. If promises are getting stuck at promise.await (no completion logs)
2. If requests are getting stuck in queues (queue size logs)
3. If send/receive fibers are failing (runner logs)
4. If error handling is working properly (error logs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds detailed logging to help identify where deadlocks occur in the Redis client. Each promise gets a unique ID to track its full lifecycle from creation to completion.
Logging added:
Log prefixes:
This will help identify deadlock scenarios in CI environments by showing: