Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy-frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
run: pnpm --filter @hena-wadeena/web build

- name: Upload build artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: upload-artifact is bumped to v7 but download-artifact on line 69 remains at v4. These companion actions should be version-aligned — bump download-artifact to v7 as well to avoid artifact download failures in the deploy job.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/deploy-frontend.yml, line 56:

<comment>`upload-artifact` is bumped to v7 but `download-artifact` on line 69 remains at v4. These companion actions should be version-aligned — bump `download-artifact` to v7 as well to avoid artifact download failures in the deploy job.</comment>

<file context>
@@ -53,7 +53,7 @@ jobs:
 
       - name: Upload build artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: frontend-dist
</file context>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 upload-artifact bumped to v7 but download-artifact left at v4, breaking artifact transfer between jobs

The build job uploads artifacts with actions/upload-artifact@v7 (line 56), but the deploy job still downloads with actions/download-artifact@v4 (line 69). The upload-artifact and download-artifact actions must use compatible major versions because major version bumps change the underlying artifact backend. This version mismatch will cause the deploy job to fail to retrieve the artifact uploaded by the build job, breaking the entire frontend deployment pipeline.

Prompt for agents
The upload-artifact action was bumped to v7 but the corresponding download-artifact action at line 69 was not updated. These two actions must use compatible major versions to function correctly. Either revert upload-artifact back to v4 to match the existing download-artifact@v4, or bump download-artifact to v7 as well (at .github/workflows/deploy-frontend.yml line 69: change `actions/download-artifact@v4` to `actions/download-artifact@v7`).
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

with:
name: frontend-dist
path: apps/web/dist/
Expand Down
Loading