unify integration banks depsit/withdraw instructions - #535
Open
IMEF-FEMI wants to merge 12 commits into
Open
Conversation
IMEF-FEMI
marked this pull request as ready for review
March 17, 2026 15:24
jgur-psyops
reviewed
Mar 17, 2026
jgur-psyops
reviewed
Mar 17, 2026
…d deposit instructions
…on-deposit-withdraw
IliaZyrin
reviewed
Mar 30, 2026
…dler validation, and cover the unified path with tests
…e-pin JupLend rewards_rate_model to the lending account
…t fuzz type drift
…o withdrawals fail at the venue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates all wrapped-integration user deposit and withdraw flows behind a single interface: integration_deposit and integration_withdraw. Instead of maintaining separate entrypoints for Kamino, Drift, Solend, and JupLend, marginfi now shares one common validation, accounting, rate-limit, health-check, and event pipeline, while keeping only the protocol-specific CPI logic isolated in per-integration handlers.
Motivation
The previous pattern duplicated the most security-sensitive parts of the flow across multiple integrations. Authorization, paused-state handling, deleverage accounting, rate-limiter enforcement, health validation, cache updates, and event emission were all copied per-protocol. Every change had to be replicated across nearly-identical handlers, raising the odds of inconsistent fixes and integration-specific gaps.
Changes
Advantages