add max borrow withdraw query - #640
Open
ashleychandy wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a no-op instruction to query the maximum amount a marginfi account can borrow or withdraw from a given bank without reproducing the on-chain risk engine off-chain.
The instruction simulates borrow/withdraw operations using the existing risk checks and emits the result as an event, making it easy to consume via RPC simulation.
Changes
lending_account_query_max_borrow_withdrawinstructionQueryMaxBorrowWithdrawEventfor RPC simulation outputis_allwhen the entire user balance can be withdrawnFixes #627