Reject leverage and fee configs that would leave a position unliquidable - #644
Open
IMEF-FEMI wants to merge 8 commits into
Open
Reject leverage and fee configs that would leave a position unliquidable#644IMEF-FEMI wants to merge 8 commits into
IMEF-FEMI wants to merge 8 commits into
Conversation
IMEF-FEMI
changed the title
# Conflicts: # programs/marginfi/src/instructions/marginfi_account/liquidate.rs # programs/marginfi/tests/user_actions/liquidate.rs
IliaZyrin
approved these changes
Aug 18, 2026
…the LIQUIDATION_HEALTH_GAIN_MARGIN doc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents the configuring of positions whose liquidator fee cannot be paid.
A liquidation only clears while the liquidatee's credit outweighs the seized collateral, which leaves
1 / leverageof room for fees. A bank whose liquidator fee exceeds that room has its realized fee is silently degraded below the configured rate: at a 0.99 collateral weight a bank configured for 2.5% pays the liquidator 1.0%, and the insurance cut reaches zero. Nothing errors and nothing is logged. This PR makes that config rejected at write time instead.The relationship is checked whenever either side moves: when e-mode entries are set, when a bank's liquidator fee changes, and when a bank opts into same-asset e-mode, whose weights are synthesized from the group's leverage rather than stored as entries.