Skip to content

seven seas 43 #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kingofclubstroyDev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

seven seas 43 #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions client/library/library/audits/sevenSeas-43.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<page
clientName="Seven Seas"
reportDate="May 12, 2025"
auditTitle="Seven Seas A-43"
auditVersion="1.0.0"
repoUrl="https://github.com/Veda-Labs/boring-vault"
layout="/library/audits/_layout.html"
customRepoInfo
>

<content-for name="schedule">
The security audit was performed by the Macro security team on March 9th, 2025.
</content-for>

<content-for name="spec">
<ul>
<li>Discussions with the {{page.clientName}} team.</li>
<li>Available documentation in the repository.</li>
</ul>
</content-for>

<content-for name="repo-info">
<ul>

<li class="break-words break-all">
<b>Silo Vault Decoder (from <a href="https://github.com/Veda-Labs/boring-vault/pull/279">PR 279</a>)</b> </br>
Commit Hash: <code>f472abafb22f7a45e81df2814ae4bdf6f56dd74a</code>
<template type="file-hashes">
6d1473116f67ef6d45898d9ec11311947dee8c7538c992ee76eb721b3cec584b src/base/DecodersAndSanitizers/Protocols/SiloDecoderAndSanitizer.sol </template>
</li>

<li class="break-words break-all">
<b>wSwell unwrapping Decoder (from <a href="https://github.com/Veda-Labs/boring-vault/pull/280">PR 280</a>)</b> </br>
Commit Hash: <code>187e7b0b619dfdcbe78273d41b7fe24d1bb22ed7</code>
<template type="file-hashes">
45a3b3aac352288db286b41d2ab67ac0a8dfe2f0ff4b93f60da781a86ddd70c2 src/base/DecodersAndSanitizers/Protocols/wSwellUnwrappingDecoderAndSanitizer.sol </template>
</li>

</ul>
</content-for>
</page>
2 changes: 1 addition & 1 deletion content/collections/private
Open in desktop
Submodule private updated from ed76d2 to a5c80f
30 changes: 30 additions & 0 deletions content/collections/public/sevenSeas-43-issues.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<item>
<field name="topic">Missing Functionality</field>
<field name="impact">medium</field>
<field name="status">fixed</field>
<field name="commit">a6aaea2dbd5ef48a8560934a85ec4dab6adf3eee</field>
<field name="content">
## [Q-1] Permit2 decoder doesn’t support `lockdown`

For the `Permit2DecoderAndSanitizer`, it could be useful to allow revoking approvals by supporting the `lockdown` function.

**Remediation to Consider**
Add the [`lockdown` function](https://github.com/Uniswap/permit2/blob/main/src/interfaces/IAllowanceTransfer.sol#L157) to the Permit2DecoderAndSanitizer.
</field>
</item>


<item>
<field name="topic">Missing Functionality</field>
<field name="impact">medium</field>
<field name="status">fixed</field>
<field name="commit">fd105d16ef992bfd33fe346907e08d34f3818f52</field>
<field name="content">
## [Q-2] Royco decoder doesn’t support cancelling offers on the `VaultMarketHub`

The `RoycoDecoderAndSanitizer` allows creating AP (action provider) offers on both the RecipeMarketHub and VaultMarketHub. While offer cancellation is implemented for RecipeMarketHub through `cancelAPOffer`, no equivalent cancellation function exists for VaultMarketHub.

**Remediation to Consider**
Add support for cancelling offers on the VaultMarketHub by implementing the `cancelOffer` function.
</field>
</item>