AggLayer: validate destination_network during bridge-out#2778
Open
Fumuran wants to merge 2 commits intoandrew-validate-destination-network-bridge-infrom
Open
AggLayer: validate destination_network during bridge-out#2778Fumuran wants to merge 2 commits intoandrew-validate-destination-network-bridge-infrom
destination_network during bridge-out#2778Fumuran wants to merge 2 commits intoandrew-validate-destination-network-bridge-infrom
Conversation
Fumuran
added
no changelog
mmagician
added
the
agglayer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an AggLayer-aligned guard on bridge-out: a
B2AGGnote’s destination network ID must not equal Miden’s AggLayer network ID (MIDEN_NETWORK_ID). This matches the rule that an exit cannot target the current chain as its destination, and complements the existing CLAIM path that requires leaves to target Miden as the destination.Changes
bridge_out.masm: Early inbridge_out, assertdestination_network ≠ MIDEN_NETWORK_ID. New errorERR_B2AGG_DESTINATION_NETWORK_IS_MIDEN.b2agg.masm/SPEC.md: Document the new failure mode in theB2AGG/bridge-outflow.bridge_out.rs:test_bridge_out_fails_when_destination_is_miden_network— registered faucet, B2AGG note withAggLayerBridge::MIDEN_NETWORK_ID, expects the new error.Closes: #2747