Skip to content

Enable concurrent feature for miden-tx in bench-transaction#2790

Merged
Al-Kindi-0 merged 2 commits intonextfrom
al/fix-bench-tx-concurrent
Apr 17, 2026
Merged

Enable concurrent feature for miden-tx in bench-transaction#2790
Al-Kindi-0 merged 2 commits intonextfrom
al/fix-bench-tx-concurrent

Conversation

@Al-Kindi-0
Copy link
Copy Markdown
Collaborator

While working on a variation of #2391, found the issue probably causing 0xMiden/node#1862

Screenshot 2026-04-17 at 3 34 12 PM

@Al-Kindi-0 Al-Kindi-0 added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Apr 17, 2026
@Al-Kindi-0 Al-Kindi-0 added this pull request to the merge queue Apr 17, 2026
Merged via the queue into next with commit f895f46 Apr 17, 2026
17 checks passed
@Al-Kindi-0 Al-Kindi-0 deleted the al/fix-bench-tx-concurrent branch April 17, 2026 14:48
@bobbinth
Copy link
Copy Markdown
Contributor

cc @Mirko-von-Leipzig and @igamigo in case this is relevant in node/client.

@igamigo
Copy link
Copy Markdown
Collaborator

igamigo commented Apr 17, 2026

In the client we do enable concurrent everywhere we can, but it seems that we don't in the node. Created a PR here. I think running integration tests from the client does get a little faster, but not by a lot (and still if I run on the previous level of concurrency the contention still kills the machine).

@bobbinth
Copy link
Copy Markdown
Contributor

In the client we do enable concurrent everywhere we can, but it seems that we don't in the node. Created a PR here.

Approved! I do wonder if we should just always enable concurrent when std is enabled. I don't see a reason why we'd want to run with std but not concurrent.

@Mirko-von-Leipzig
Copy link
Copy Markdown
Contributor

In the client we do enable concurrent everywhere we can, but it seems that we don't in the node. Created a PR here.

Approved! I do wonder if we should just always enable concurrent when std is enabled. I don't see a reason why we'd want to run with std but not concurrent.

If you do then please just remove the feature entirely? Having features that should always be selected is.. just weird

afa7789 pushed a commit to afa7789/miden-base that referenced this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants