fix(apps-npm-release): give snapshot changeset version a GITHUB_TOKEN#47
Merged
Merged
Conversation
Repos on @changesets/changelog-github (now the Apps Team default) invoke the GitHub API via @changesets/get-github-info during `changeset version`, which aborts without a token. The release job sets GITHUB_TOKEN on changesets/action, but the snapshot job runs `changeset version --snapshot` directly with only SNAPSHOT_TAG in its env, so canary/snapshot publishes fail for every changelog-github repo. Add read-only `github.token` (the snapshot job never commits or pushes, so no app token is needed).
MaximusHaximus
requested review from
grajat90,
py-zoid and
shan8851
as code owners
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
1 similar comment
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Apps Team default changelog formatter is now
@changesets/changelog-github(rolled out across repos recently). That formatter calls the GitHub API via@changesets/get-github-infoduringchangeset versionand aborts without aGITHUB_TOKEN.The
releasejob setsGITHUB_TOKENon thechangesets/actionstep, but thesnapshotjob runschangeset version --snapshotdirectly with onlySNAPSHOT_TAGin its env — so every canary/snapshot publish now fails at the version step for any changelog-github repo:(Hit live dispatching a matic.js canary on its keep-alive fix branch.)
Fix
Add read-only
GITHUB_TOKEN: ${{ github.token }}to the snapshot job'sVersion snapshotstep. The snapshot job never commits or pushes (--no-git-tag), so the default token's read scope is sufficient — no app token needed.Scope
Repairs canary/snapshot publishing for all changelog-github consumers (api-gateway, balance-api, gas-station, lst-api, pos-airdrop, staker-pool-allocations, subgraphs, static, matic.js, apps-team-packages, proof-generation-api, and the template). Standard
push-triggered releases are unaffected.