Conversation
0xb4lamx
left a comment
0xb4lamx
left a comment
There was a problem hiding this comment.
2MB diff between the 2 versions? xD
but AFAIU "Distroless is for Security if not for Size" 🤔
| ======= | ||
| # Local | ||
| docker-compose.yml | ||
| *.env |
There was a problem hiding this comment.
.env files should not be pushed to git.
we prepared an .env.example to clone from locally 🤔
There was a problem hiding this comment.
that env file is loaded by docker-compose in build phase, it evals the docker compose and change the ${VARS} by its equivalent.
| new DailyRotateFile({ | ||
| level: 'debug', | ||
| filename: `./logs/${this.nodeEnv}/debug-%DATE%.log`, | ||
| filename: `${process.env.HOME}/${this.nodeEnv}/debug-%DATE%.log`, |
There was a problem hiding this comment.
we need to find a better location for this.
we can't keep ./logs/* and mount it in docker to be consistent? 🤔 (from developer perspective who uses docker and local env interchangeably)
There was a problem hiding this comment.
We can play with an env var and default it to env.home if not defined what do you think about it ?
| @@ -0,0 +1,149 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Good stuff, we need to update README accoding to this? for better experience using the new CLI 🤔
(didn't test it intensively yet)
3 participants
Migration to Distroless base image on release stage