fix(p0-1): npm wrapper fake success — ENOENT + PATH persistence + --no-init

npm/bin/autosearch-ai.js

@@ -48,6 +48,49 @@ function hasAutosearch() {
   return getInstalledAutosearchVersion() !== null;
 }
 
+function expectedAutosearchPath() {
+  if (isWindows()) {
+    return "%USERPROFILE%\\AppData\\Roaming\\Python\\Python312\\Scripts\\autosearch.exe";
+  }
+  return `${process.env.HOME || "~"}/.local/bin/autosearch`;
+}
+
+function prependHomeLocalBinToPath() {
+  if (!process.env.HOME) return;
+
+  const localBin = `${process.env.HOME}/.local/bin`;
+  const separator = isWindows() ? ";" : ":";
+  const currentPath = process.env.PATH || "";
+  if (currentPath.split(separator).includes(localBin)) return;
+
+  process.env.PATH = currentPath
+    ? `${localBin}${separator}${currentPath}`
+    : localBin;
+}
+
+function printAutosearchNotFoundHint(error) {
+  process.stderr.write(
+    `\nautosearch not found after install.\n` +
+      `Expected executable: ${expectedAutosearchPath()}\n` +
+      `Your PATH may not include the install location yet.\n` +
+      `Re-source your shell profile or install AutoSearch directly:\n` +
+      `  curl -fsSL ${INSTALL_SCRIPT} | bash\n` +
+      `  pipx install autosearch && autosearch init\n` +
+      `  pip install --user autosearch && autosearch init\n` +
+      (error?.message ? `\nOriginal error: ${error.message}\n` : "\n"),
+  );
+}
+
+function printInstallerNotFoundHint(error) {
+  process.stderr.write(
+    `\nUnable to start the AutoSearch installer.\n` +
+      `The underlying installer command was not found. Ensure one of these ` +
+      `commands is available on PATH: curl, bash, pipx, py, python.\n` +
+      `Then re-run: npx autosearch-ai --yes\n` +
+      (error?.message ? `\nOriginal error: ${error.message}\n` : "\n"),
+  );
+}
+
 // Bug 6 (fix-plan v8 follow-up): compare the wrapper's expected Python CLI
 // version against what's actually installed. The npm package version
 // `YYYY.M.DD` derives from pyproject `YYYY.MM.DD.N` (N is the daily counter
@@ -226,15 +269,24 @@ async function main() {
       }
     }
     const result = runInstall();
+    if (result.error?.code === "ENOENT") {
+      printInstallerNotFoundHint(result.error);
+      process.exit(1);
+    }
     if ((result.status ?? 0) !== 0) {
       process.exit(result.status ?? 1);
     }
+    prependHomeLocalBinToPath();
   } else {
     checkVersionAlignment(installedVersion);
   }
 
   const cmd = args.length > 0 ? args : ["init"];
   const result = spawnSync("autosearch", cmd, { stdio: "inherit" });
+  if (result.error?.code === "ENOENT") {
+    printAutosearchNotFoundHint(result.error);
+    process.exit(1);
+  }
   process.exit(result.status ?? 0);
 }
 

scripts/install.sh

@@ -7,6 +7,7 @@ GREEN="\033[32m"
 YELLOW="\033[33m"
 RED="\033[31m"
 RESET="\033[0m"
+ORIGINAL_PATH="$PATH"
 
 info()    { echo -e "${BOLD}$*${RESET}"; }
 success() { echo -e "${GREEN}✓${RESET} $*"; }
@@ -16,6 +17,7 @@ die()     { echo -e "${RED}✗${RESET} $*" >&2; exit 1; }
 # ── Flag parsing ─────────────────────────────────────────────────────────────
 DRY_RUN=false
 NO_INIT=false
+CHECK_PATH_PERSISTENCE=false
 VERSION=""
 
 usage() {
@@ -33,6 +35,8 @@ Flags:
                     config separately.
   --version VER     Pin a specific version (e.g. 2026.04.24.4) instead of
                     installing the latest. Applies to uv / pipx / pip.
+  --check-path-persistence
+                    Check shell-profile PATH persistence logic, then exit.
   -h, --help        Show this help.
 EOF
 }
@@ -41,6 +45,7 @@ while [[ $# -gt 0 ]]; do
   case "$1" in
     --dry-run)     DRY_RUN=true; shift ;;
     --no-init)     NO_INIT=true; shift ;;
+    --check-path-persistence) CHECK_PATH_PERSISTENCE=true; shift ;;
     --version)     [[ -z "${2:-}" ]] && die "--version requires an argument"; VERSION="$2"; shift 2 ;;
     --version=*)   VERSION="${1#--version=}"; shift ;;
     -h|--help)     usage; exit 0 ;;
@@ -130,24 +135,46 @@ fix_path() {
 }
 
 # ── 4. Persist PATH to shell profile ─────────────────────────────────────────
+shell_profile() {
+  case "$(basename "${SHELL:-}")" in
+    zsh)  echo "$HOME/.zshrc" ;;
+    bash) echo "$HOME/.bashrc" ;;
+    *)    echo "$HOME/.profile" ;;
+  esac
+}
+
 persist_path() {
   local line='export PATH="$HOME/.local/bin:$PATH"'
-  for profile in "$HOME/.zshrc" "$HOME/.bashrc" "$HOME/.profile"; do
-    if [ -f "$profile" ] && ! grep -q '.local/bin' "$profile" 2>/dev/null; then
-      if [[ "$DRY_RUN" == true ]]; then
-        printf "  [dry-run] would append PATH export to %s\n" "$profile"
-      else
-        echo "" >> "$profile"
-        echo "# Added by AutoSearch installer" >> "$profile"
-        echo "$line" >> "$profile"
-        warn "Added ~/.local/bin to PATH in $profile"
-      fi
-      break
-    fi
-  done
+  local profile
+
+  if [[ ":$ORIGINAL_PATH:" == *":$HOME/.local/bin:"* ]]; then
+    return 0
+  fi
+
+  profile="$(shell_profile)"
+  if [[ -f "$profile" ]] && grep -Fqx "$line" "$profile" 2>/dev/null; then
+    return 0
+  fi
+
+  if [[ "$DRY_RUN" == true ]]; then
+    printf "  [dry-run] would append PATH export to %s\n" "$profile"
+    return 0
+  fi
+
+  mkdir -p "$(dirname "$profile")"
+  touch "$profile"
+  echo "" >> "$profile"
+  echo "# Added by AutoSearch installer" >> "$profile"
+  echo "$line" >> "$profile"
+  warn "Added ~/.local/bin to PATH in $profile"
 }
 
 # ── Main ─────────────────────────────────────────────────────────────────────
+if [[ "$CHECK_PATH_PERSISTENCE" == true ]]; then
+  persist_path
+  exit 0
+fi
+
 install_autosearch
 fix_path
 
@@ -163,8 +190,9 @@ if [[ "$DRY_RUN" == true ]]; then
   exit 0
 fi
 
+persist_path
+
 if ! command -v autosearch &>/dev/null; then
-  persist_path
   fix_path
 fi
 

tests/smoke/test_npm_wrapper.py

@@ -1,5 +1,6 @@
 import json
 import os
+import shutil
 import subprocess
 from pathlib import Path
 
@@ -67,3 +68,86 @@ def test_npm_pack_dry_run_has_no_install_lifecycle_scripts(
     packed_files = {entry["path"] for entry in pack_output[0]["files"]}
     assert "package.json" in packed_files
     assert "bin/autosearch-ai.js" in packed_files
+
+
+def test_spawn_enoent_returns_nonzero(tmp_path: Path) -> None:
+    fake_bin = tmp_path / "bin"
+    fake_bin.mkdir()
+    fake_autosearch = fake_bin / "autosearch"
+    fake_autosearch.write_text(
+        "#!/bin/sh\n"
+        'if [ "$1" = "--version" ]; then\n'
+        f'  rm -f "{fake_autosearch}"\n'
+        '  echo "2026.4.24.1"\n'
+        "  exit 0\n"
+        "fi\n"
+        'echo "unexpected autosearch invocation" >&2\n'
+        "exit 2\n",
+        encoding="utf-8",
+    )
+    fake_autosearch.chmod(0o755)
+
+    env = os.environ.copy()
+    env["PATH"] = os.pathsep.join([str(fake_bin), "/usr/bin", "/bin"])
+
+    result = subprocess.run(
+        [
+            shutil.which("node") or "node",
+            str(NPM_DIR / "bin" / "autosearch-ai.js"),
+            "doctor",
+        ],
+        cwd=ROOT,
+        env=env,
+        capture_output=True,
+        text=True,
+        timeout=30,
+        check=False,
+    )
+
+    assert result.returncode != 0
+    assert "autosearch not found" in result.stderr.lower()
+    assert "path" in result.stderr.lower()
+
+
+def test_path_after_install_finds_binary(tmp_path: Path) -> None:
+    home = tmp_path / "home"
+    home.mkdir()
+    fake_bin = tmp_path / "bin"
+    fake_bin.mkdir()
+    fake_bash = fake_bin / "bash"
+    fake_bash.write_text(
+        "#!/bin/sh\n"
+        'mkdir -p "$HOME/.local/bin"\n'
+        'cat > "$HOME/.local/bin/autosearch" <<\'EOF\'\n'
+        "#!/bin/sh\n"
+        'echo "installed autosearch $*"\n'
+        "exit 0\n"
+        "EOF\n"
+        'chmod +x "$HOME/.local/bin/autosearch"\n'
+        "exit 0\n",
+        encoding="utf-8",
+    )
+    fake_bash.chmod(0o755)
+
+    env = os.environ.copy()
+    env["HOME"] = str(home)
+    env["PATH"] = os.pathsep.join([str(fake_bin), "/usr/bin", "/bin"])
+
+    result = subprocess.run(
+        [
+            shutil.which("node") or "node",
+            str(NPM_DIR / "bin" / "autosearch-ai.js"),
+            "--yes",
+            "doctor",
+        ],
+        cwd=ROOT,
+        env=env,
+        capture_output=True,
+        text=True,
+        timeout=30,
+        check=False,
+    )
+
+    combined_output = result.stdout + result.stderr
+    assert result.returncode == 0, combined_output
+    assert "installed autosearch doctor" in result.stdout

tests/unit/test_install_sh_flags.py

@@ -9,6 +9,7 @@
 
 from __future__ import annotations
 
+import os
 import subprocess
 from pathlib import Path
 
@@ -69,3 +70,49 @@ def test_unknown_flag_is_rejected() -> None:
     result = _run("--definitely-not-a-flag")
     assert result.returncode != 0, "unknown flag must exit non-zero"
     assert "unknown flag" in result.stderr.lower() or "unknown flag" in result.stdout.lower()
+
+
+def test_install_persists_path_when_not_in_original(tmp_path: Path) -> None:
+    profile = tmp_path / ".zshrc"
+    profile.write_text("# existing profile\n", encoding="utf-8")
+
+    env = os.environ.copy()
+    env["HOME"] = str(tmp_path)
+    env["PATH"] = "/usr/bin:/bin"
+    env["SHELL"] = "/bin/zsh"
+
+    result = subprocess.run(
+        ["bash", str(INSTALL_SH), "--check-path-persistence"],
+        capture_output=True,
+        text=True,
+        timeout=30,
+        env=env,
+    )
+
+    expected_line = 'export PATH="$HOME/.local/bin:$PATH"'
+    combined_output = result.stdout + result.stderr
+    assert result.returncode == 0, combined_output
+    assert expected_line in profile.read_text(encoding="utf-8")
+
+    already_configured_home = tmp_path / "already-configured"
+    already_configured_home.mkdir()
+    already_configured_profile = already_configured_home / ".zshrc"
+    original_profile = "# existing profile\n"
+    already_configured_profile.write_text(original_profile, encoding="utf-8")
+
+    env["HOME"] = str(already_configured_home)
+    env["PATH"] = os.pathsep.join(
+        [str(already_configured_home / ".local" / "bin"), "/usr/bin", "/bin"]
+    )
+
+    result = subprocess.run(
+        ["bash", str(INSTALL_SH), "--check-path-persistence"],
+        capture_output=True,
+        text=True,
+        timeout=30,
+        env=env,
+    )
+
+    combined_output = result.stdout + result.stderr
+    assert result.returncode == 0, combined_output
+    assert already_configured_profile.read_text(encoding="utf-8") == original_profile