fix: defer protected content status check until init - #211
Open
rickalee wants to merge 1 commit into
Open
Conversation
Evaluate the Protected Content feature while ElasticPress validates feature requirements on init instead of during Co-Authors Plus construction on plugins_loaded. Closes 10up#210 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 50c48fa8-36d5-c9ca8a0c82fa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initThis keeps feature registration available before ElasticPress processes registered features while avoiding ElasticPress translation calls during
plugins_loaded. The dependency state is still populated before the Co-Authors Plus feature setup runs.Closes #210
Testing instructions
EP_HOST.vendor/bin/phpunit tests/phpunit/feature/TestCoAuthorsPlus.php.vendor/bin/phpcs includes/classes/Feature/CoAuthorsPlus.php tests/phpunit/feature/TestCoAuthorsPlus.php --runtime-set testVersion 7.4-.Test results