Skip to content

Fix --only flag: respect all post types #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jessedyck wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix --only flag: respect all post types #250

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52671e6
Fix --only flag silently dropping custom post type IDs
jessedyck Jul 18, 2026
75026be
Add MigrationAgent tests for --only flag behaviour
jessedyck Jul 18, 2026
8bf4e7c
Merge branch 'develop' into fix/only-flag-post-type-pagination
jeffpaul Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion includes/ConvertToBlocks/MigrationAgent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,8 @@ public function get_posts_to_update( $opts = [] ) {
$post_in = array_map( 'intval', $post_in );
$post_in = array_filter( $post_in );

$query_params['post__in'] = $post_in;
$query_params['post__in'] = $post_in;
$query_params['post_type'] = 'any';

@peterwilsoncc peterwilsoncc Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the migration agent requires the user to open the posts in their browser, it's probably best to limit this to posts that have an admin UI. any can include posts without one.

}

$query = new \WP_Query( $query_params );
Expand Down
55 changes: 55 additions & 0 deletions tests/ConvertToBlocks/MigrationAgentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
<?php

namespace ConvertToBlocks;

class MigrationAgentTest extends \WP_UnitTestCase {

public $agent;

function setUp(): void {
parent::setUp();
$this->agent = new MigrationAgent();
}

function test_get_posts_to_update_returns_only_specified_ids() {
$post_id = self::factory()->post->create( [ 'post_status' => 'publish' ] );
$page_id = self::factory()->post->create( [ 'post_type' => 'page', 'post_status' => 'publish' ] );
$extra_id = self::factory()->post->create( [ 'post_status' => 'publish' ] );

$posts = $this->agent->get_posts_to_update( [ 'only' => "$post_id,$page_id" ] );

$this->assertContains( $post_id, $posts );
$this->assertContains( $page_id, $posts );
$this->assertNotContains( $extra_id, $posts );
}

function test_get_posts_to_update_includes_custom_post_types_when_using_only() {
register_post_type( 'ctb_test_cpt', [ 'public' => true ] );

$post_id = self::factory()->post->create( [ 'post_status' => 'publish' ] );
$cpt_id = self::factory()->post->create( [ 'post_type' => 'ctb_test_cpt', 'post_status' => 'publish' ] );

$posts = $this->agent->get_posts_to_update( [ 'only' => "$post_id,$cpt_id" ] );

$this->assertContains( $post_id, $posts );
$this->assertContains( $cpt_id, $posts, '--only should include custom post type IDs' );

unregister_post_type( 'ctb_test_cpt' );
}

function test_get_posts_to_update_without_only_excludes_custom_post_types_by_default() {
register_post_type( 'ctb_test_cpt', [ 'public' => true ] );

$post_id = self::factory()->post->create( [ 'post_status' => 'publish' ] );
$cpt_id = self::factory()->post->create( [ 'post_type' => 'ctb_test_cpt', 'post_status' => 'publish' ] );

$posts = $this->agent->get_posts_to_update( [] );

$this->assertContains( $post_id, $posts );
$this->assertNotContains( $cpt_id, $posts, 'default query should not include custom post types' );

unregister_post_type( 'ctb_test_cpt' );
}


}
Loading