Bump Wordpress Version minimum requirement 6.6#1312
Merged
Conversation
Minimum Requirement Version 6.6
Sourabh208
requested review from
vikrampm1
and removed request for
a team and
jeffpaul
github-actions
bot
added
the
needs:feedback
|
@Sourabh208 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
Member
|
e2e tests are failing, @10up/open-source-practice will want to check what's happening there before merging this in |
vikrampm1
previously approved these changes
Apr 25, 2025
peterwilsoncc
force-pushed
the
Bump-require-at-least-wordpress-version-6.6
branch
from
a607947 to
39071ad
Compare
Collaborator
|
@jeffpaul The failed tests were false negatives caused by some DOM changes with regard to how the media library was injected in to the page. 39071ad includes a fix for this by ensuring that the copy of the media library the tests interact with is the visible. I've pushed a related change to the artifact names so that failures from multiple test runs are included when applicable. |
jeffpaul
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #1308
How to test the Change
Follow the critical flows to test the PR
Changelog Entry
@ankitguptaindia @jeffpaul @vikrampm1 I've created this PR to address the closure of issue #1308 . In this update, I've only modified the minimum required WordPress version to 6.6.