Skip to content

filter by identified status#42

Open
idiglove wants to merge 4 commits into12products:mainfrom
idiglove:filter-by-status
Open

filter by identified status#42
idiglove wants to merge 4 commits into12products:mainfrom
idiglove:filter-by-status

Conversation

@idiglove
Copy link
Copy Markdown
Contributor

@idiglove idiglove commented Mar 3, 2022

Screen Shot 2022-03-10 at 3 45 57 PM

@amorriscode
Copy link
Copy Markdown
Member

Hey @idiglove, thanks for putting this together!

I'd actually like to see this implemented in a different way so that we can lean on the existing routes for incidents, as well as the existing pages. It's a bit different from your approach and it's totally my bad because the ticket lacked detail.

Here's what I was thinking:

  • Have a "filter" bar that goes on the top of the IncidentsTable
  • That bar would have various filters (in this case, one for Status)
  • Selecting from an option for filtering would add a query param to the route

Then, on the backend, our GraphQL queries for incidents can take optional filtering params. This approach would be more dynamic and reusable.

Does that make sense? Let me know if you have any other ideas or questions I can clear up. Sorry again for the lack of direction in the ticket!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants