Open
Conversation
Member
|
Hey @idiglove, thanks for putting this together! I'd actually like to see this implemented in a different way so that we can lean on the existing routes for incidents, as well as the existing pages. It's a bit different from your approach and it's totally my bad because the ticket lacked detail. Here's what I was thinking:
Then, on the backend, our GraphQL queries for incidents can take optional filtering params. This approach would be more dynamic and reusable. Does that make sense? Let me know if you have any other ideas or questions I can clear up. Sorry again for the lack of direction in the ticket! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.