Skip to content

Don't refresh local caches so often #5998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yuvipanda wants to merge 2 commits into from
Closed

Don't refresh local caches so often #5998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc708d3
Don't refresh local caches so often
yuvipanda Apr 30, 2025
cfa8d18
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions deployer/commands/validate/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,21 +54,26 @@ def _prepare_helm_charts_dependencies_and_schemas():
Ensures that the helm charts we deploy, basehub and daskhub, have got their
dependencies updated and .json schema files generated so that they can be
"""
# Run helm repo update once so we can skip refreshing local cache each time
# we run `helm dep up`
subprocess.check_call(["helm", "repo", "update"])
basehub_dir = HELM_CHARTS_DIR.joinpath("basehub")
_generate_values_schema_json(basehub_dir)
subprocess.check_call(["helm", "dep", "up", basehub_dir])
subprocess.check_call(["helm", "dep", "up", "--skip-refresh", basehub_dir])

daskhub_dir = HELM_CHARTS_DIR.joinpath("daskhub")
# Not generating schema for daskhub, as it is dead
subprocess.check_call(["helm", "dep", "up", daskhub_dir])
subprocess.check_call(["helm", "dep", "up", "--skip-refresh", daskhub_dir])

support_dir = HELM_CHARTS_DIR.joinpath("support")
_generate_values_schema_json(support_dir)
subprocess.check_call(["helm", "dep", "up", support_dir])
subprocess.check_call(["helm", "dep", "up", "--skip-refresh", support_dir])

aws_ce_grafana_backend = HELM_CHARTS_DIR.joinpath("aws-ce-grafana-backend")
_generate_values_schema_json(aws_ce_grafana_backend)
subprocess.check_call(["helm", "dep", "up", aws_ce_grafana_backend])
subprocess.check_call(
["helm", "dep", "up", "--skip-refresh", aws_ce_grafana_backend]
)


def get_list_of_hubs_to_operate_on(cluster_name, hub_name):
Expand Down
2 changes: 1 addition & 1 deletion deployer/infra_components/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def deploy_support(self, cert_manager_version, debug):
print_colour("Provisioning support charts...")

support_dir = HELM_CHARTS_DIR.joinpath("support")
subprocess.check_call(["helm", "dep", "up", support_dir])
subprocess.check_call(["helm", "dep", "up", "--skip-refresh", support_dir])

# contains both encrypted and unencrypted values files
values_file_paths = [
Expand Down
Loading