Skip to content

clean-Up: Variational formulation#43

Merged
10 commits merged into
mainfrom
feat/variational-model_fixes
Feb 25, 2026
Merged

clean-Up: Variational formulation#43
10 commits merged into
mainfrom
feat/variational-model_fixes

Conversation

@pillowbeast

@pillowbeast pillowbeast commented Feb 20, 2026

Copy link
Copy Markdown
Collaborator

Further Tasks for Generalized Backend

Missing:

  • config clarification of f (two descriptions available) (-> src/weac/components/layer.py)
  • no Tests for generalized mode (-> tests/...)
  • Double Gi/Gii/Gii implementation with one commented out, should remove one (-> src/weac/core/generalized_field_quanitites.py)

Clarifications @Flo-rhein

  • f: In file src/weac/components/layer.py on lines 233 /257 we have two descriptions. Which one of the two is the correct description? resultant force or weight density?
  • Two implementations: In Generalized Quantities there are two implementations for Gi/Gii/Giii. Can we remove the comments or is there a reason to keep these in.
  • Tests: Utility Tests + Regression Tests are required, showing, verifying that the structures returned by the generalized backend still work with the criteria evaluator. Also regression tests help breaking changes in the future.

…alized mode

- Bug Fix: generalized backend was invokable with slab touchdown
- Refactored force decomposition tests in `test_misc.py` to include rotation angle (theta) and use x/y/z notation
Copilot AI review requested due to automatic review settings February 20, 2026 16:29
@coderabbitai

This comment was marked as outdated.

This comment was marked as outdated.

coderabbitai[bot]

This comment was marked as outdated.

- setup logging in jupyter notebook
- rm .env.example from .gitignore
coderabbitai[bot]

This comment was marked as outdated.

coderabbitai[bot]

This comment was marked as outdated.

coderabbitai[bot]

This comment was marked as outdated.

coderabbitai[bot]

This comment was marked as outdated.

@pillowbeast pillowbeast closed this pull request by merging all changes into main in ad9e55a Feb 25, 2026
@pillowbeast pillowbeast deleted the feat/variational-model_fixes branch February 25, 2026 13:35
@pillowbeast pillowbeast restored the feat/variational-model_fixes branch February 25, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants