Skip to content

Snowpylot-bump #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pillowbeast merged 2 commits into from
Apr 20, 2026
Merged

Snowpylot-bump #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16735cb
updated snowpylot dependency
pillowbeast Apr 20, 2026
7103c75
bump version
pillowbeast Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ jobs:
env:
TWINE_USERNAME: __token__
TWINE_PASSWORD: ${{ secrets.PYPI_API_TOKEN }}
run: uv run twine upload dist/*
run: uv run twine upload dist/* --verbose
2 changes: 1 addition & 1 deletion CITATION.cff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ authors:
- family-names: "Weissgraeber"
given-names: "Philipp"
orcid: "https://orcid.org/0000-0001-8320-8672"
version: 3.1.5
version: 3.1.6
date-released: 2021-12-30
identifiers:
- description: Collection of archived snapshots of all versions of WEAC
Expand Down
2 changes: 1 addition & 1 deletion demo/demo.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"id": "695bafcb",
"metadata": {},
"source": [
"Note that instructions in this notebook refer to **release v3.1.5.** Please make sure you are running the latest version of weac using\n",
"Note that instructions in this notebook refer to **release v3.1.6.** Please make sure you are running the latest version of weac using\n",
"\n",
"```bash\n",
"pip install -U weac\n",
Expand Down
7 changes: 3 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "weac"
version = "3.1.5"
version = "3.1.6"
authors = [{ name = "2phi GbR", email = "mail@2phi.de" }]
description = "Weak layer anticrack nucleation model"
readme = "README.md"
Expand All @@ -23,8 +23,7 @@ dependencies = [
"numpy>=2.3.5,<2.4.0",
"scipy>=1.14.0",
"pydantic>=2.11.7",
# Required for SLF CAAML parsing; can upgrade once version >=1.1.5 is released
"snowpylot @ git+https://github.com/connellymk/snowpylot.git@e1a0d7c3f16a05ea97f75e97bdacece86ac4704b",
"snowpylot>=1.1.5",

@coderabbitai coderabbitai Bot Apr 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Consider adding an upper bound on snowpylot.

The spec snowpylot>=1.1.5 is unbounded, so any future 2.x (potentially breaking) release will be accepted at install time. The WEAC codebase depends on a fairly specific surface of the snowpylot API (caaml_parser, snowpylot.layer.Layer, snowpylot.snow_pit.SnowPit, snowpylot.snow_profile.DensityObs, plus tuple-shaped attributes like thickness, depth_top, grain_form_primary.grain_size_avg, etc. — see src/weac/utils/snowpilot_parser.py), which makes it vulnerable to silent breakage on a major bump.

Given the other pinning style in this file (e.g. numpy>=2.3.5,<2.4.0), a compatible-range constraint would be safer:

📦 Proposed constraint 
-    "snowpylot>=1.1.5",
+    "snowpylot>=1.1.5,<2",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"snowpylot>=1.1.5",
"snowpylot>=1.1.5,<2",
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@pyproject.toml` at line 26, Update the unbounded dependency spec for
snowpylot to use a compatible upper bound (e.g. change "snowpylot>=1.1.5" to a
caret/range-style pin like "snowpylot>=1.1.5,<2.0.0" or "snowpylot~=1.1.5") in
pyproject.toml so major breaking releases are excluded; follow the same pinning
style used for numpy (e.g. numpy>=2.3.5,<2.4.0) to protect code that depends on
snowpylot APIs referenced in src/weac/utils/snowpilot_parser.py (caaml_parser,
snowpylot.layer.Layer, snowpylot.snow_pit.SnowPit,
snowpylot.snow_profile.DensityObs, and tuple-shaped attributes like
thickness/depth_top/grain_form_primary.grain_size_avg).

]

[project.urls]
Expand Down Expand Up @@ -127,7 +126,7 @@ ignore = [
]

[tool.bumpversion]
current_version = "3.1.5"
current_version = "3.1.6"

[[tool.bumpversion.files]]
filename = "pyproject.toml"
Expand Down
2 changes: 1 addition & 1 deletion src/weac/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
WEAC - Weak Layer Anticrack Nucleation Model
"""

__version__ = "3.1.5"
__version__ = "3.1.6"
10 changes: 7 additions & 3 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading