Add configurable texture output folder for appearance export#80
Closed
yaozhihang wants to merge 1 commit into
Closed
Add configurable texture output folder for appearance export#80yaozhihang wants to merge 1 commit into
yaozhihang wants to merge 1 commit into
Conversation
Member
|
Hi @yaozhihang, I have a few questions:
|
Member
Author
Path baseDirectory = helper.getOptions().getOutputFile().getFile().getParent();
if (baseDirectory != null
&& !baseDirectory.resolve(outputFolder).normalize().startsWith(baseDirectory)) {
throw new IllegalArgumentException("The texture output folder must be a relative path "
+ "inside the export target, but was '" + outputFolder + "'.");
}
|
Member
Author
|
@clausnagel I found another workaround to avoid touching this API. We could close this PR if you think a hard-coded output texture folder is necessary |
Member
|
Sounds good. I'll close this for now, but feel free to reopen it if you'd like to continue the discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, textures are always exported to the fixed default relative folder
appearance. This PR adds a newtextureOutputFolderoption toAppearanceOptions, allowing users to customize the relative folder where exported textures are written.