Conversation
|
Thanks for the PR! Im taking a look at this now |
|
@spolisar I love this PR, thank you for finding a great solution to the overwriting logging issue |
|
I wrote a simple example that replicates the issue I ran into, and led to this pull request, in this gist. main.py doesn't get squarelib's logger or set it up to display logs, so you'd expect no logs to appear in the terminal when running. That does not happen, we get log messages printed out in the console when running the streamlit app. If you comment out From what I understand about logging in python, there's a hierarchy/structure to loggers. Libraries like streamlit-analytics2, urllib3, or squarelib from the example should have their own logger that can fit into that hierarchy properly rather than using the root logging functions from the logging library. Most of what I'm saying here is stuff I learned recently, so there may be mistakes. |
Pull Request Template
TL;DR
getLogger()Problem Solved
Changes Made(Optional)
List the main changes in bullet points.
Manual Testing
How was this tested?
Describe the tests that you ran to verify your changes.
Additional Notes