Add per particle dbcs#1895
Merged
georghammerl merged 1 commit into4C-multiphysics:mainfrom Mar 31, 2026
Merged
Conversation
georghammerl
force-pushed
the
add_per_particle_dbcs
branch
3 times, most recently
from
52e6375 to
7a65f0e
Compare
ppraegla
reviewed
Mar 27, 2026
sebproell
reviewed
Mar 27, 2026
sebproell
reviewed
Mar 29, 2026
slfuchs
reviewed
Mar 29, 2026
Contributor
slfuchs
left a comment
slfuchs
left a comment
There was a problem hiding this comment.
I also like this feature a lot! This enables not only simple moving boundaries in SPH but more complex examples
georghammerl
force-pushed
the
add_per_particle_dbcs
branch
2 times, most recently
from
3f9741c to
fa49c46
Compare
slfuchs
previously approved these changes
Mar 30, 2026
georghammerl
force-pushed
the
add_per_particle_dbcs
branch
from
fa49c46 to
90d2745
Compare
ppraegla
previously approved these changes
Mar 30, 2026
Member
ppraegla
left a comment
ppraegla
left a comment
There was a problem hiding this comment.
One question and some nitpicking
georghammerl
force-pushed
the
add_per_particle_dbcs
branch
from
90d2745 to
e58d26e
Compare
ppraegla
requested changes
Mar 31, 2026
Member
ppraegla
left a comment
ppraegla
left a comment
There was a problem hiding this comment.
Nice work. Sorry, for another round of comments 🙈
georghammerl
force-pushed
the
add_per_particle_dbcs
branch
from
e58d26e to
cf030a8
Compare
ppraegla
approved these changes
Mar 31, 2026
slfuchs
approved these changes
Mar 31, 2026
Contributor
slfuchs
left a comment
slfuchs
left a comment
There was a problem hiding this comment.
Looks good from my side!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context
Extracted the per particle Dirichlet boundary condition from #1881 into a separate PR.
The first review comments are already included from the original PR.
DIRICHLET_FUNCTin particle definitions (e.g.,"TYPE pdphase POS ... DIRICHLET_FUNCT 1")DIRICHLET_FUNCT 1are subject to a Dirichlet boundary condition prescribed byFUNCT1Related Issues and Pull Requests
(#1881)
Interested parties
@alhermann