[pull] main from czlonkowski:main - #122
Merged
Merged
Conversation
…d additional-property rejections (v2.77.0) (#1048) * fix: refresh rotated multi-tenant credentials and name the keys behind additional-property rejections (v2.77.0) Fixes #1045: in the instance session strategy, a session's InstanceContext was frozen at creation and its configHash covered only the URL and instance ID, so rotating the n8n API key or the instance-level MCP access token neither changed the session's config identity nor reached the live session. The hash input now includes both credentials (only the 8-char digest ever appears in session IDs and logs), and a non-initialize request carrying the complete tenant identity for the same instance refreshes the live session's context. Separately, exportSessionState/restoreSessionState rebuilt the context field by field and silently dropped n8nMcpAccessToken (and the timeout/retry tuning); SessionState['context'] is now derived from InstanceContext, and both sides copy the declared fields through a compile-time-checked key list that also keeps undeclared embedder properties out of the persisted plaintext. Fixes #1047: n8n's "must NOT have additional properties" 400 never names the offending key. When the rejection hits request/body or request/body/settings, the error now appends the key names that were actually sent (tracked per attempt, so the group-degradation ladder never blames a key absent from the failing request), flags settings keys missing from the known-settings table, surfaces n8n's own additionalProperty when it is unambiguous, and logs the enriched message so hosted deployments see it in container logs. Key names only, never values. Conceived by Romuald Członkowski - www.aiadvisors.pl/en Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0183xmTCSmpvqRSbLyAvGrGN * fix: merge instance-strategy context refresh over stored fields and pin the session URL (Copilot review) A non-initialize request that omits optional fields (the MCP access token, timeout/retry tuning) no longer clears them on refresh — omitted fields mean "unchanged". The refresh also requires the stored n8nApiUrl to match: a changed URL is a different config identity and goes through initialize instead of retargeting a live session. Conceived by Romuald Członkowski - www.aiadvisors.pl/en Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0183xmTCSmpvqRSbLyAvGrGN * fix: key the session config fingerprint with the server auth token (CodeQL js/insufficient-password-hash) The truncated sha256 over url+instanceId+credentials was an unkeyed fingerprint: anyone reading a session ID or the logs could verify credential guesses offline against the 8 hex chars. HMAC-SHA256 keyed with AUTH_TOKEN keeps the hash deterministic per deployment (any legitimate hash-comparing consumer already holds the token) while removing the oracle. Flagged independently by CodeQL, the code review, and the Codex review. Conceived by Romuald Członkowski - www.aiadvisors.pl/en Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0183xmTCSmpvqRSbLyAvGrGN --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )