[pull] main from czlonkowski:main - #97
Merged
Merged
Conversation
…o the database (#937) (#939) The loader's node-name regex only matched .node.js/.node.ts, so EvaluationTrigger.node.ee.js produced a garbage node name, and the export-resolution fallback took the module's first export — the numeric constant DEFAULT_STARTING_ROW, not the node class — so parsing failed and nodes-base.evaluationTrigger was silently dropped from every rebuild. Agents could not discover it and validate_workflow falsely rejected valid evaluation workflows with "Unknown node type". - Accept an optional .ee segment in the node-name regex - Resolve the node class only from function-typed exports (shared resolveNodeClass helper for both manifest formats) - Add nodes-base.evaluation and nodes-base.evaluationTrigger to the canonical core-node completeness gate so a silent drop fails the build - Add fixture-based regression tests exercising the real loader - Rebuild the node database: 827 core nodes (677 n8n-nodes-base + 150 @n8n/n8n-nodes-langchain) Fixes #937 Conceived by Romuald Członkowski - www.aiadvisors.pl/en Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )