Record the fifth review's medium and minor findings - #64
Merged
Conversation
Eighteen of the twenty-two findings are now closed, across five PRs. What is left is deliberate rather than forgotten, and the report says which is which. M5 — a root file with no settings block passes in the editor and fails at build — has no free fix: nothing in the file distinguishes "this is a root" from "this is a fragment", and the relaxation that fragments need is the same one that hides the error for a root. The four remaining minor items each want a new language rule or a rework rather than a patch: sibling arrays differing only in case, the insertion-order dependence of the case-insensitive lookup, completion having no scope awareness, and two URIs for one file. Rushing any of them would trade a known defect for an unknown one. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
18 des 22 constats de la cinquième revue sont clos, en cinq PR (#57 → #63). 364 → 381 tests.
Ce qui reste, et pourquoi
Ce n'est pas un reliquat d'oubli mais d'arbitrage, et le rapport le dit explicitement.
M5 — un fichier racine sans bloc
settingsest propre dans l'éditeur et échoue au build — n'a pas de correctif gratuit : rien dans le fichier ne distingue « ceci est une racine » de « ceci est un fragment », et la relaxation dont les fragments ont besoin est exactement celle qui masque l'erreur pour une racine.Les quatre mineurs restants demandent chacun soit une nouvelle règle de langage, soit une refonte :
Les bâcler reviendrait à échanger un défaut connu contre un défaut inconnu.
🤖 Generated with Claude Code