Make the landing example and the web API sample true - #68
Merged
Conversation
Fixes H6 of the sixth cold review — the two things a new user reads first, both
of them wrong.
The landing page showed a block labelled "appsettings.Production.json (generated)"
containing ApplicationName, which delta output does not emit. The same page's own
blurb, and the entire CLI page, insist output is a delta, so the hero example
contradicted the headline feature. It now shows what the compiler actually
produces.
samples/SampleWebApi did not compile: it used ${JWT_SECRET_STAGING} and six
similar placeholders as if interpolation resolved runtime environment variables,
which is precisely the anti-pattern the README warns against two pages earlier.
The keys now carry an obvious placeholder value so the shape of the configuration
stays visible, with a header explaining that the real value arrives at deployment
through .NET's environment-variable or user-secrets provider, layered on top of
these files.
Generated JSON under samples/ is no longer committed. Those files had gone stale
in the same way as the ones at the repository root and in the demo project: merged
content from before delta became the default, and in one case missing an entire
environment added since. The .settex sources are the artefacts worth keeping.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrige H6 de la sixième revue — les deux premières choses qu'un nouvel utilisateur lit, toutes deux fausses.
L'exemple phare de la page d'accueil
Le bloc étiqueté «
appsettings.Production.json(généré) » contenaitApplicationName, que la sortie delta n'émet pas. Le texte de la même page, et toute la page CLI, insistent pourtant sur le fait que la sortie est un delta : l'exemple vedette contredisait la fonctionnalité vedette. Il montre désormais ce que le compilateur produit réellement.samples/SampleWebApine compilait pasIl utilisait
${JWT_SECRET_STAGING}et six autres placeholders comme si l'interpolation résolvait des variables d'environnement à l'exécution — précisément l'anti-patron que le README déconseille deux pages plus tôt.Les clés portent maintenant une valeur de remplacement évidente, pour que la forme de la configuration reste visible, avec un en-tête expliquant que la vraie valeur arrive au déploiement via le fournisseur de variables d'environnement ou de secrets utilisateur de .NET, superposé à ces fichiers.
Le JSON généré sous
samples/n'est plus commitéCes fichiers avaient vieilli exactement comme ceux de la racine et du projet de démo : contenu fusionné d'avant le mode delta, et dans un cas un environnement entier manquant, ajouté depuis. Les sources
.settexsont les artefacts qui méritent d'être suivis.🤖 Generated with Claude Code