Skip to content

Add output_dir parameter to upload method #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baelter wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

Add output_dir parameter to upload method #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
107c96f
Add output_dir parameter to upload method
baelter Mar 25, 2026
5be3d4f
Validate output_dir and clarify missing index.html error
claude Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions lib/website/deployer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,14 @@ def content_type(f)
CACHE_CONTROL = "public, max-age=60, s-maxage=60, stale-while-revalidate=60,"\
" stale-if-error=60"

def upload(domain, force_deploy: false)
output_dir = render
def upload(domain, force_deploy: false, output_dir: nil)
if output_dir
unless Dir.exist?(output_dir)
raise ArgumentError, "output_dir #{output_dir.inspect} does not exist"
end
else
output_dir = render
end
s3 = Aws::S3::Resource.new
bucket = s3.bucket(domain)
objects = bucket.objects
Expand All @@ -84,7 +90,7 @@ def upload(domain, force_deploy: false)
files = Dir["**/*"].select { |f| File.file? f }
unless files.any? { |f| f =~ /index\.html$/ }
puts "at=debug no index found, files=#{files}"
raise "Render failed!"
raise "No index.html found in #{output_dir}"
end
changed = []
objects.each do |obj|
Expand Down