refactor: load config as value object#2041
Merged
balanza merged 10 commits into89luca89:nextfrom Apr 2, 2026
Merged
Conversation
dottorblaster
requested changes
Apr 1, 2026
Collaborator
dottorblaster
left a comment
dottorblaster
left a comment
There was a problem hiding this comment.
Just some feedbacks but great work overall (also thank you for addressing this ❤️ )
The current implementation uses dotenv to load the configuration into the environment, and then delegate the cli layer to handle the configuration coming from the DBX_ variables. With this new implementation, defaults, config files and environment variables are handled in a single point and treated as values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the way we handle configuration so that, instead of collapsing the file values into the environment, the entire configuration is calculated and passed as a value object to the commands.
This allows the default container image and name to be configurable (see: 24e9ed8).
Expected benefits
pkg/config/config.go)godotenvWhat changed
internal/configmoved topkg/configFixes #2040 (the fix: 24e9ed8)