Bugfixes that allow the project to work on Laravel versions up to current.#6
Open
bddarwin wants to merge 6 commits intoA-Lawrence:masterfrom
Open
Bugfixes that allow the project to work on Laravel versions up to current.#6bddarwin wants to merge 6 commits intoA-Lawrence:masterfrom
bddarwin wants to merge 6 commits intoA-Lawrence:masterfrom
Conversation
…rent. Fixing src/Console/TestCommand.php to use the updated "handle" function to run an artisan command (previous function was fire, which seems to be documented as outdated as of Laravel 5.1 and removed in Laravel 5.5) Fixing src/ServiceProvider.php to use singleton() instead of share() -- share is removed in Laravel 5.4 Fixing composer.json to add autoloading support, making the config/app.php file edits no longer required. Fixing readme.md to reference the support for more recent Laravel versions as well as the new autoload support for versions 5.5 and greater Signed-off-by: bddarwin <bddarwin@gmail.com>
Apply fixes from StyleCI
Apply fixes from StyleCI -- Apparently I forgot to apply the laravel specific ones in this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfixes that allow the project to work on Laravel versions up to current.
Fixing src/Console/TestCommand.php to use the updated "handle"
function to run an artisan command (previous function was fire,
which seems to be documented as outdated as of Laravel 5.1 and
removed in Laravel 5.5)
Fixing src/ServiceProvider.php to use singleton() instead of
share() -- share is removed in Laravel 5.4
Fixing composer.json to add autoloading support, making the
config/app.php file edits no longer required.
Fixing readme.md to reference the support for more recent Laravel
versions as well as the new autoload support for versions 5.5 and
greater
Signed-off-by: bddarwin bddarwin@gmail.com