Open
Conversation
mduncans
commented
Apr 8, 2026
mduncans
commented
Apr 8, 2026
Collaborator
Author
There was a problem hiding this comment.
unreferenced snapshot
Keats
requested changes
Apr 9, 2026
| expression: "rendered.join(\"\\n\")" | ||
| input_file: components/nonmem-parser/test_data/errors/omega_same_no_preceding_block.mod | ||
| --- | ||
| error: SAME must immediately follow a BLOCK(2) |
Collaborator
There was a problem hiding this comment.
that specific test is confusing since it literally follows a BLOCK(2). Can we point the block before as a note?
Collaborator
Author
There was a problem hiding this comment.
Ahh yeah this is confusing, I'll update the control stream to be more meaningful. What this is supposed to show is that a block same has to come after a block or block same.
$OMEGA BLOCK(2) SD CORR
0.2
0.3 0.15
$OMEGA 0.04
$OMEGA BLOCK(2) SAME
Is invalid: case29_same_intervening
| .collect() | ||
| } | ||
|
|
||
| fn uniform_diagonal_parametrization(&self, node: &CstNode) -> Option<Parametrization> { |
Collaborator
There was a problem hiding this comment.
can you add an example? I don't really get the body of the function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the parameterization and handling of Omega and Sigma blocks. Tests have been run in nonmem to verify valid/invalid control streams. The results are saved to nonmem-parser/docs/nm-test-results.md
OMEGA/SIGMA blocks now carry either Cholesky parameterization or Diagonal + Off-diagonal parameterization, to allow for blocks like: (case15_block_sd_corr)
Flags like FIX, SD, CORR, etc apply to the entire block not the individual parameters.
OmegaSigmaParamthemselves no longer carry the fixed flag (case19_block_fix_inline). Because of thisget_omega_parametersnow also givesblock_fixedBLOCK(N) SAME must follow a BLOCK(N) or BLOCK(N) SAME block (case29_same_intervening)
NAMES is only applicable on BLOCK (reject08_names_diagonal)