Support monorepo packages from local paths#361
Open
andyquinterom wants to merge 7 commits intoA2-ai:mainfrom
Open
Support monorepo packages from local paths#361andyquinterom wants to merge 7 commits intoA2-ai:mainfrom
andyquinterom wants to merge 7 commits intoA2-ai:mainfrom
Conversation
Member
|
Just want to let you know we haven't forgotten about this - we have some client deadlines this week and also this feature will take some extra careful consideration to make sure we understand what we are committing to. We appreciate you pushing some code through to keep this moving and should be able to get this in place sooner rather than later. We are committed to getting it into rv at this point. |
Member
|
ok we are coming back to address this ~ this week 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I worked on top of #359
Currently running the bootstrap.R file only works for Git Repos, however for local development it is not uncommon to use paths.
This pull request adds the same directory parameter to local packages.
I'm unsure if this is the best name for the parameter as there is both
pathanddirectoryand it might me confusing.For these monorepo like structures, path would be the path to the root of the monorepo and directory the path to the R package.
I have added an example project with the same package on the git monorepo test, but local.
I'm open to implementing anything needed to get these monorepo features going.