placementNew/placementDelete: simplify with if constexpr and trivially_copyable#5522
Closed
WeiqunZhang wants to merge 1 commit into
Closed
placementNew/placementDelete: simplify with if constexpr and trivially_copyable#5522WeiqunZhang wants to merge 1 commit into
WeiqunZhang wants to merge 1 commit into
Conversation
…y_copyable Replace the three requires-overloads of placementNew with a single function using if constexpr. Use std::is_trivially_copyable instead of std::is_trivially_default_constructible — trivially copyable types (including arithmetic and POD types) begin their lifetime implicitly once storage is allocated and need no placement-new. Add matching Doxygen comments for both functions.
Member
Author
|
Oh, there is EBCellFlagFab that depends on the default ctor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the three requires-overloads of placementNew with a single function using if constexpr. Use std::is_trivially_copyable instead of std::is_trivially_default_constructible — trivially copyable types (including arithmetic and POD types) begin their lifetime implicitly once storage is allocated and need no placement-new. Add matching Doxygen comments for both functions.
Breaking change: BaseFab no longer default-constructs trivially copyable element types. Code that relied on BaseFab allocation/resize to initialize values, including BaseFab<GpuComplex> zero-initialization, must explicitly fill or write the data before reading it. This is consistent with the existing behavior for arithmetic types, which are not initialized on allocation; in that sense, the new behavior is arguably the less surprising one for BaseFab storage.